You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Chia-Ping Tsai (Jira)" <ji...@apache.org> on 2024/07/15 22:09:00 UTC

[jira] [Created] (KAFKA-17140) 'make tools' should check the version of tools

Chia-Ping Tsai created KAFKA-17140:
--------------------------------------

             Summary: 'make tools' should check the version of tools
                 Key: KAFKA-17140
                 URL: https://issues.apache.org/jira/browse/KAFKA-17140
             Project: Kafka
          Issue Type: Improvement
            Reporter: Chia-Ping Tsai
            Assignee: Chia-Ping Tsai


Makefile, by default, checks only the existence of file. Hence, developers need to remove tools folder (or call `make distclean`) manually to trigger the installation after we update the version of tools.

However, how developers can be aware of the tools updates? Personally, I smell fishy from the error of warning, but that could be implicit and noisy :cry

In order to fix that, I'd like to introduce the new folder structure to tools folder: /tools/{tool_name}/{version}. That offers a unique path to each version of tool. Developers will not miss the updates anymore.

NOTED: we need to remove the existent tool binary if there is naming conflict in creating the new path. For example, creating /tools/golangci-lint/1.57.2 will fail if /tools/golangci-lint is a existent file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)