You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2014/12/10 12:33:04 UTC
Review Request 28541: LENS-102 : Keeping join order same in rewritten
and input query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28541/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Summary (updated)
-----------------
LENS-102 : Keeping join order same in rewritten and input query
Bugs: LENS-102
https://issues.apache.org/jira/browse/LENS-102
Repository: lens
Description (updated)
-------
Constructing join tree by parsing recursively from AST reverses the order of join conditions. Same input order should be maintained in the rewritten query.
Diffs
-----
Diff: https://reviews.apache.org/r/28541/diff/
Testing (updated)
-------
Ensured that the input join order and rewritten join order are same and made necessary changes in unit test.
File Attachments (updated)
----------------
LENS-102_1.patch
https://reviews.apache.org/media/uploaded/files/2014/12/10/b1c9da9c-e24e-4bbe-b28d-6bccfe2765b1__LENS-102_1.patch
Thanks,
Sushil Mohanty
Re: Review Request 28541: LENS-102 : Keeping join order same in
rewritten and input query
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28541/#review64531
-----------------------------------------------------------
Ship it!
Looks like some trailing whitespace is there. Other than that code looks good.
- Jaideep dhok
On Dec. 10, 2014, 12:12 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28541/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 12:12 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-102
> https://issues.apache.org/jira/browse/LENS-102
>
>
> Repository: lens
>
>
> Description
> -------
>
> Constructing join tree by parsing recursively from AST reverses the order of join conditions. Same input order should be maintained in the rewritten query.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java d5808ae
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java e5ec5b1
>
> Diff: https://reviews.apache.org/r/28541/diff/
>
>
> Testing
> -------
>
> Ensured that the input join order and rewritten join order are same and made necessary changes in unit test.
>
>
> File Attachments
> ----------------
>
> LENS-102_1.patch
> https://reviews.apache.org/media/uploaded/files/2014/12/10/b1c9da9c-e24e-4bbe-b28d-6bccfe2765b1__LENS-102_1.patch
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 28541: LENS-102 : Keeping join order same in
rewritten and input query
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28541/
-----------------------------------------------------------
(Updated Dec. 10, 2014, 12:12 p.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-102
https://issues.apache.org/jira/browse/LENS-102
Repository: lens
Description
-------
Constructing join tree by parsing recursively from AST reverses the order of join conditions. Same input order should be maintained in the rewritten query.
Diffs (updated)
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java d5808ae
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java e5ec5b1
Diff: https://reviews.apache.org/r/28541/diff/
Testing
-------
Ensured that the input join order and rewritten join order are same and made necessary changes in unit test.
File Attachments
----------------
LENS-102_1.patch
https://reviews.apache.org/media/uploaded/files/2014/12/10/b1c9da9c-e24e-4bbe-b28d-6bccfe2765b1__LENS-102_1.patch
Thanks,
Sushil Mohanty