You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/28 09:25:44 UTC

Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57130/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20227
    https://issues.apache.org/jira/browse/AMBARI-20227


Repository: ambari


Description
-------

The dialog box will be closed on successful saving and submission of workflow and the success message is shown on the parent window.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e94d51a 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js f6e11b6 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 9eb20aa 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 017bc61 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 4ff9d87 

Diff: https://reviews.apache.org/r/57130/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam


Re: Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57130/#review167057
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 28, 2017, 9:25 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57130/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20227
>     https://issues.apache.org/jira/browse/AMBARI-20227
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The dialog box will be closed on successful saving and submission of workflow and the success message is shown on the parent window.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e94d51a 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js f6e11b6 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 9eb20aa 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 017bc61 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 4ff9d87 
> 
> Diff: https://reviews.apache.org/r/57130/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57130/#review167033
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 28, 2017, 9:25 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57130/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20227
>     https://issues.apache.org/jira/browse/AMBARI-20227
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The dialog box will be closed on successful saving and submission of workflow and the success message is shown on the parent window.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e94d51a 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js f6e11b6 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 9eb20aa 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 017bc61 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 4ff9d87 
> 
> Diff: https://reviews.apache.org/r/57130/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>