You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kim Jin Chul (Code Review)" <ge...@cloudera.org> on 2017/11/24 04:42:17 UTC
[Impala-ASF-CR] IMPALA-3784: Fixed borken status-benchmark on debug
Kim Jin Chul has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8641
Change subject: IMPALA-3784: Fixed borken status-benchmark on debug
......................................................................
IMPALA-3784: Fixed borken status-benchmark on debug
A default constructed boost::optional is empty - it does
not contain a value, so get() cannot be called. The value
check should be required before using it.
Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
---
M be/src/benchmarks/status-benchmark.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/8641/1
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1522/
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 14:42:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 18:19:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Kim Jin Chul (Code Review)" <ge...@cloudera.org>.
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8641
to look at the new patch set (#2).
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
IMPALA-3784: Fixed broken status-benchmark
A default constructed boost::optional is empty - it does
not contain a value, so get() cannot be called. The value
check should be required before using it.
Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
---
M be/src/benchmarks/status-benchmark.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/8641/2
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 2
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Kim Jin Chul (Code Review)" <ge...@cloudera.org>.
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG@7
PS1, Line 7: borken
> nit: "broken"
Done
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG@7
PS1, Line 7: on debug
> nit: omit this. It looks like a bug in either case :-)
Done
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 09:38:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3784: Fixed borken status-benchmark on debug
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed borken status-benchmark on debug
......................................................................
Patch Set 1:
(2 comments)
Nice work!
When this is committed, I'd suggest we leave IMPALA-3784 open for the release compilation issue, if it still exists (which it might not).
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG@7
PS1, Line 7: on debug
nit: omit this. It looks like a bug in either case :-)
http://gerrit.cloudera.org:8080/#/c/8641/1//COMMIT_MSG@7
PS1, Line 7: borken
nit: "broken"
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Sun, 26 Nov 2017 20:29:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
IMPALA-3784: Fixed broken status-benchmark
A default constructed boost::optional is empty - it does
not contain a value, so get() cannot be called. The value
check should be required before using it.
Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Reviewed-on: http://gerrit.cloudera.org:8080/8641
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M be/src/benchmarks/status-benchmark.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jim Apple: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
[Impala-ASF-CR] IMPALA-3784: Fixed broken status-benchmark
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8641 )
Change subject: IMPALA-3784: Fixed broken status-benchmark
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fcdbdb4c5bc432a4d224dda821de132e3bca611
Gerrit-Change-Number: 8641
Gerrit-PatchSet: 3
Gerrit-Owner: Kim Jin Chul <ji...@gmail.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Kim Jin Chul <ji...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 14:42:33 +0000
Gerrit-HasComments: No