[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners

[GitBox <gi...@apache.org>]

gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r664435639



##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
       zookeeperServers: zk1:2181,zk2:2181,zk3:2181
       configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
       pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+      SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080

Review comment:
       Sorry late response, I think the config `web-service-url` could replace the config `broker-service-url` completly, if the config `web-service-url` is set, the `broker-service-url` will be useless, refer to https://github.com/apache/pulsar/blob/master/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorConfig.java#L90




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org