You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Remi Bergsma <RB...@schubergphilis.com> on 2016/01/10 13:23:38 UTC

Pull Requests we should include in 4.7.1 / 4.8.0

Hi all,

Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.

Regards,
Remi


Easy to test/review UI fixes:
=============================

#1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
https://github.com/apache/cloudstack/pull/1327

#1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
https://github.com/apache/cloudstack/pull/1325

#1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
https://github.com/apache/cloudstack/pull/1301

#1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
https://github.com/apache/cloudstack/pull/1300

VPN support for Sonicwall devices:
==================================

#1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
https://github.com/apache/cloudstack/pull/1317

VPC/router bug fixes:
=====================

#1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
https://github.com/apache/cloudstack/pull/1318

#1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
https://github.com/apache/cloudstack/pull/1299

#1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
https://github.com/apache/cloudstack/pull/1298

#1276 [4.7] FIX Site2SiteVPN on redundant VPC
https://github.com/apache/cloudstack/pull/1276

#1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
https://github.com/apache/cloudstack/pull/1277

#1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
https://github.com/apache/cloudstack/pull/1291

#1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
https://github.com/apache/cloudstack/pull/1296


I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.

Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.


Features:
=========

#1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
https://github.com/apache/cloudstack/pull/1297

#872 Strongswan vpn feature <== needs serious testing
https://github.com/apache/cloudstack/pull/872

Bug fixes:
==========

#1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
https://github.com/apache/cloudstack/pull/1321

#1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
https://github.com/apache/cloudstack/pull/1309

#1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
https://github.com/apache/cloudstack/pull/1278

#1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
https://github.com/apache/cloudstack/pull/1272

#1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
https://github.com/apache/cloudstack/pull/1198

#866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
https://github.com/apache/cloudstack/pull/866/files



PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
https://github.com/apache/cloudstack/pull/1289






Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Simon Weller <sw...@ena.com>.
It looks like we are close on the Ceph deletion PR as well:

https://github.com/apache/cloudstack/pull/1230

That one would be well received by anyone running Ceph.
 
- Si




________________________________________
From: Wido den Hollander <wi...@widodh.nl>
Sent: Sunday, January 10, 2016 1:20 PM
To: dev@cloudstack.apache.org
Subject: Re: Pull Requests we should include in 4.7.1 / 4.8.0

On 01/10/2016 01:23 PM, Remi Bergsma wrote:
> Hi all,
>
> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
>

Seems good to me! I think they are good stuff to put in to 4.8!

> Regards,
> Remi
>
>
> Easy to test/review UI fixes:
> =============================
>
> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
> https://github.com/apache/cloudstack/pull/1327
>
> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
> https://github.com/apache/cloudstack/pull/1325
>
> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
> https://github.com/apache/cloudstack/pull/1301
>
> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
> https://github.com/apache/cloudstack/pull/1300
>
> VPN support for Sonicwall devices:
> ==================================
>
> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
> https://github.com/apache/cloudstack/pull/1317
>
> VPC/router bug fixes:
> =====================
>
> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
> https://github.com/apache/cloudstack/pull/1318
>
> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
> https://github.com/apache/cloudstack/pull/1299
>
> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
> https://github.com/apache/cloudstack/pull/1298
>
> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
> https://github.com/apache/cloudstack/pull/1276
>
> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
> https://github.com/apache/cloudstack/pull/1277
>
> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
> https://github.com/apache/cloudstack/pull/1291
>
> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
> https://github.com/apache/cloudstack/pull/1296
>
>
> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
>
> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
>
>
> Features:
> =========
>
> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
> https://github.com/apache/cloudstack/pull/1297
>
> #872 Strongswan vpn feature <== needs serious testing
> https://github.com/apache/cloudstack/pull/872
>
> Bug fixes:
> ==========
>
> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
> https://github.com/apache/cloudstack/pull/1321
>
> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
> https://github.com/apache/cloudstack/pull/1309
>
> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
> https://github.com/apache/cloudstack/pull/1278
>
> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
> https://github.com/apache/cloudstack/pull/1272
>
> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
> https://github.com/apache/cloudstack/pull/1198
>
> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
> https://github.com/apache/cloudstack/pull/866/files
>
>
>
> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
> https://github.com/apache/cloudstack/pull/1289
>
>
>
>
>

Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Wido den Hollander <wi...@widodh.nl>.
On 01/10/2016 01:23 PM, Remi Bergsma wrote:
> Hi all,
> 
> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
> 

Seems good to me! I think they are good stuff to put in to 4.8!

> Regards,
> Remi
> 
> 
> Easy to test/review UI fixes:
> =============================
> 
> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
> https://github.com/apache/cloudstack/pull/1327
> 
> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
> https://github.com/apache/cloudstack/pull/1325
> 
> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
> https://github.com/apache/cloudstack/pull/1301
> 
> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
> https://github.com/apache/cloudstack/pull/1300
> 
> VPN support for Sonicwall devices:
> ==================================
> 
> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
> https://github.com/apache/cloudstack/pull/1317
> 
> VPC/router bug fixes:
> =====================
> 
> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
> https://github.com/apache/cloudstack/pull/1318
> 
> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
> https://github.com/apache/cloudstack/pull/1299
> 
> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
> https://github.com/apache/cloudstack/pull/1298
> 
> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
> https://github.com/apache/cloudstack/pull/1276
> 
> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
> https://github.com/apache/cloudstack/pull/1277
> 
> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
> https://github.com/apache/cloudstack/pull/1291
> 
> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
> https://github.com/apache/cloudstack/pull/1296
> 
> 
> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
> 
> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
> 
> 
> Features:
> =========
> 
> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
> https://github.com/apache/cloudstack/pull/1297
> 
> #872 Strongswan vpn feature <== needs serious testing
> https://github.com/apache/cloudstack/pull/872
> 
> Bug fixes:
> ==========
> 
> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
> https://github.com/apache/cloudstack/pull/1321
> 
> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
> https://github.com/apache/cloudstack/pull/1309
> 
> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
> https://github.com/apache/cloudstack/pull/1278
> 
> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
> https://github.com/apache/cloudstack/pull/1272
> 
> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
> https://github.com/apache/cloudstack/pull/1198
> 
> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
> https://github.com/apache/cloudstack/pull/866/files
> 
> 
> 
> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
> https://github.com/apache/cloudstack/pull/1289
> 
> 
> 
> 
> 

Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Remi Bergsma <RB...@schubergphilis.com>.
Update:
We managed to get several PRs merged today thanks to a series of reviews. Great!

I updated the list below in the original mail. I do want to point some attention to these PRs:

#1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
https://github.com/apache/cloudstack/pull/1277
==> There was a firm discussion on this one and if I read it all correctly that has been resolved by removing one commit. Let’s finalise its review. We do need these fixes in the next release.
Pinging @Dahn @Koushik-das to conclude their reviews.

Quota: findbug fixes
https://github.com/apache/cloudstack/pull/1289
==> Let's finally fix all the build failures due to FindBugs (since Dec 2?).. All those build failure mails every day…
Pinging @Abhi to process comments. We also need reviewers.

Regards,
Remi


From: Remi Bergsma <RB...@schubergphilis.com>>
Date: Thursday 14 January 2016 12:24
To: "dev@cloudstack.apache.org<ma...@cloudstack.apache.org>" <de...@cloudstack.apache.org>>
Subject: Re: Pull Requests we should include in 4.7.1 / 4.8.0

Update: we managed to merge 2 PRs only…

Anyone able to help review and test these PRs?

Regards,
Remi


From: Remi Bergsma <RB...@schubergphilis.com>>
Date: Sunday 10 January 2016 13:23
To: "dev@cloudstack.apache.org<ma...@cloudstack.apache.org>" <de...@cloudstack.apache.org>>
Subject: Pull Requests we should include in 4.7.1 / 4.8.0

Hi all,

Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.

Regards,
Remi


Easy to test/review UI fixes:
=============================

#1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI [MERGED]
https://github.com/apache/cloudstack/pull/1327

#1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI [MERGED]
https://github.com/apache/cloudstack/pull/1325

#1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI [MERGED]
https://github.com/apache/cloudstack/pull/1301

#1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI [MERGED]
https://github.com/apache/cloudstack/pull/1300

VPN support for Sonicwall devices:
==================================

#1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN [MERGED]
https://github.com/apache/cloudstack/pull/1317

VPC/router bug fixes:
=====================

#1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR [CLOSED]
https://github.com/apache/cloudstack/pull/1318

#1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface [MERGED]
https://github.com/apache/cloudstack/pull/1299

#1298 CLOUDSTACK-9204 Do not error when staticroute is already gone [MERGED]
https://github.com/apache/cloudstack/pull/1298

#1276 [4.7] FIX Site2SiteVPN on redundant VPC [MERGED]
https://github.com/apache/cloudstack/pull/1276

#1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
https://github.com/apache/cloudstack/pull/1277

#1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands [MERGED]
https://github.com/apache/cloudstack/pull/1291

#1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh [MERGED]
https://github.com/apache/cloudstack/pull/1296


I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.

Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.


Features:
=========

#1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
https://github.com/apache/cloudstack/pull/1297

#872 Strongswan vpn feature <== needs serious testing
https://github.com/apache/cloudstack/pull/872

Bug fixes:
==========

#1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
https://github.com/apache/cloudstack/pull/1321

#1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
https://github.com/apache/cloudstack/pull/1309

#1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
https://github.com/apache/cloudstack/pull/1278

#1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
https://github.com/apache/cloudstack/pull/1272

#1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
https://github.com/apache/cloudstack/pull/1198

#866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
https://github.com/apache/cloudstack/pull/866/files



PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
https://github.com/apache/cloudstack/pull/1289






Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Remi Bergsma <RB...@schubergphilis.com>.
Update: we managed to merge 2 PRs only…

Anyone able to help review and test these PRs?

Regards,
Remi


From: Remi Bergsma <RB...@schubergphilis.com>>
Date: Sunday 10 January 2016 13:23
To: "dev@cloudstack.apache.org<ma...@cloudstack.apache.org>" <de...@cloudstack.apache.org>>
Subject: Pull Requests we should include in 4.7.1 / 4.8.0

Hi all,

Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.

Regards,
Remi


Easy to test/review UI fixes:
=============================

#1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI [MERGED]
https://github.com/apache/cloudstack/pull/1327

#1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI [MERGED]
https://github.com/apache/cloudstack/pull/1325

#1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
https://github.com/apache/cloudstack/pull/1301

#1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
https://github.com/apache/cloudstack/pull/1300

VPN support for Sonicwall devices:
==================================

#1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
https://github.com/apache/cloudstack/pull/1317

VPC/router bug fixes:
=====================

#1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
https://github.com/apache/cloudstack/pull/1318

#1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
https://github.com/apache/cloudstack/pull/1299

#1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
https://github.com/apache/cloudstack/pull/1298

#1276 [4.7] FIX Site2SiteVPN on redundant VPC
https://github.com/apache/cloudstack/pull/1276

#1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
https://github.com/apache/cloudstack/pull/1277

#1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
https://github.com/apache/cloudstack/pull/1291

#1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
https://github.com/apache/cloudstack/pull/1296


I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.

Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.


Features:
=========

#1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
https://github.com/apache/cloudstack/pull/1297

#872 Strongswan vpn feature <== needs serious testing
https://github.com/apache/cloudstack/pull/872

Bug fixes:
==========

#1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
https://github.com/apache/cloudstack/pull/1321

#1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
https://github.com/apache/cloudstack/pull/1309

#1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
https://github.com/apache/cloudstack/pull/1278

#1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
https://github.com/apache/cloudstack/pull/1272

#1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
https://github.com/apache/cloudstack/pull/1198

#866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
https://github.com/apache/cloudstack/pull/866/files



PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
https://github.com/apache/cloudstack/pull/1289






Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Ron Wheeler <rw...@artifact-software.com>.
Are all of the documentation PRs included now?

Ron
On 10/01/2016 7:23 AM, Remi Bergsma wrote:
> Hi all,
>
> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
>
> Regards,
> Remi
>
>
> Easy to test/review UI fixes:
> =============================
>
> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
> https://github.com/apache/cloudstack/pull/1327
>
> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
> https://github.com/apache/cloudstack/pull/1325
>
> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
> https://github.com/apache/cloudstack/pull/1301
>
> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
> https://github.com/apache/cloudstack/pull/1300
>
> VPN support for Sonicwall devices:
> ==================================
>
> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
> https://github.com/apache/cloudstack/pull/1317
>
> VPC/router bug fixes:
> =====================
>
> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
> https://github.com/apache/cloudstack/pull/1318
>
> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
> https://github.com/apache/cloudstack/pull/1299
>
> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
> https://github.com/apache/cloudstack/pull/1298
>
> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
> https://github.com/apache/cloudstack/pull/1276
>
> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
> https://github.com/apache/cloudstack/pull/1277
>
> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
> https://github.com/apache/cloudstack/pull/1291
>
> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
> https://github.com/apache/cloudstack/pull/1296
>
>
> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
>
> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
>
>
> Features:
> =========
>
> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
> https://github.com/apache/cloudstack/pull/1297
>
> #872 Strongswan vpn feature <== needs serious testing
> https://github.com/apache/cloudstack/pull/872
>
> Bug fixes:
> ==========
>
> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
> https://github.com/apache/cloudstack/pull/1321
>
> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
> https://github.com/apache/cloudstack/pull/1309
>
> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
> https://github.com/apache/cloudstack/pull/1278
>
> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
> https://github.com/apache/cloudstack/pull/1272
>
> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
> https://github.com/apache/cloudstack/pull/1198
>
> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
> https://github.com/apache/cloudstack/pull/866/files
>
>
>
> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
> https://github.com/apache/cloudstack/pull/1289
>
>
>
>
>


-- 
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102


Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Ron Wheeler <rw...@artifact-software.com>.
Did anyone change anything that is not documented or that changes 
existing documentation?

Do the people who accept PRs look at documentation as part of the 
process and create JIRA issues if the docs need changing?

Ron

On 11/01/2016 4:02 AM, Sebastien Goasguen wrote:
>> On Jan 10, 2016, at 3:54 PM, Ron Wheeler <rw...@artifact-software.com> wrote:
>>
>> Are all of the documentation issues fixed?
> there are no open PR on the docs repos.
>
>> Does the documentation reflect the 4.7.1/4.8 release?
>> Are there any new issues that need to be created to update the documentation?
>>
>> Ron
>>
>>
>> On 10/01/2016 7:23 AM, Remi Bergsma wrote:
>>> Hi all,
>>>
>>> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
>>>
>>> Regards,
>>> Remi
>>>
>>>
>>> Easy to test/review UI fixes:
>>> =============================
>>>
>>> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
>>> https://github.com/apache/cloudstack/pull/1327
>>>
>>> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
>>> https://github.com/apache/cloudstack/pull/1325
>>>
>>> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
>>> https://github.com/apache/cloudstack/pull/1301
>>>
>>> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
>>> https://github.com/apache/cloudstack/pull/1300
>>>
>>> VPN support for Sonicwall devices:
>>> ==================================
>>>
>>> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
>>> https://github.com/apache/cloudstack/pull/1317
>>>
>>> VPC/router bug fixes:
>>> =====================
>>>
>>> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
>>> https://github.com/apache/cloudstack/pull/1318
>>>
>>> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
>>> https://github.com/apache/cloudstack/pull/1299
>>>
>>> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
>>> https://github.com/apache/cloudstack/pull/1298
>>>
>>> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
>>> https://github.com/apache/cloudstack/pull/1276
>>>
>>> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
>>> https://github.com/apache/cloudstack/pull/1277
>>>
>>> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
>>> https://github.com/apache/cloudstack/pull/1291
>>>
>>> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
>>> https://github.com/apache/cloudstack/pull/1296
>>>
>>>
>>> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
>>>
>>> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
>>>
>>>
>>> Features:
>>> =========
>>>
>>> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
>>> https://github.com/apache/cloudstack/pull/1297
>>>
>>> #872 Strongswan vpn feature <== needs serious testing
>>> https://github.com/apache/cloudstack/pull/872
>>>
>>> Bug fixes:
>>> ==========
>>>
>>> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
>>> https://github.com/apache/cloudstack/pull/1321
>>>
>>> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
>>> https://github.com/apache/cloudstack/pull/1309
>>>
>>> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
>>> https://github.com/apache/cloudstack/pull/1278
>>>
>>> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
>>> https://github.com/apache/cloudstack/pull/1272
>>>
>>> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
>>> https://github.com/apache/cloudstack/pull/1198
>>>
>>> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
>>> https://github.com/apache/cloudstack/pull/866/files
>>>
>>>
>>>
>>> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
>>> https://github.com/apache/cloudstack/pull/1289
>>>
>>>
>>>
>>>
>>>
>>
>> -- 
>> Ron Wheeler
>> President
>> Artifact Software Inc
>> email: rwheeler@artifact-software.com
>> skype: ronaldmwheeler
>> phone: 866-970-2435, ext 102
>>
>


-- 
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102


Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Sebastien Goasguen <ru...@gmail.com>.
> On Jan 10, 2016, at 3:54 PM, Ron Wheeler <rw...@artifact-software.com> wrote:
> 
> Are all of the documentation issues fixed?

there are no open PR on the docs repos.

> 
> Does the documentation reflect the 4.7.1/4.8 release?
> Are there any new issues that need to be created to update the documentation?
> 
> Ron
> 
> 
> On 10/01/2016 7:23 AM, Remi Bergsma wrote:
>> Hi all,
>> 
>> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
>> 
>> Regards,
>> Remi
>> 
>> 
>> Easy to test/review UI fixes:
>> =============================
>> 
>> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
>> https://github.com/apache/cloudstack/pull/1327
>> 
>> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
>> https://github.com/apache/cloudstack/pull/1325
>> 
>> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
>> https://github.com/apache/cloudstack/pull/1301
>> 
>> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
>> https://github.com/apache/cloudstack/pull/1300
>> 
>> VPN support for Sonicwall devices:
>> ==================================
>> 
>> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
>> https://github.com/apache/cloudstack/pull/1317
>> 
>> VPC/router bug fixes:
>> =====================
>> 
>> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
>> https://github.com/apache/cloudstack/pull/1318
>> 
>> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
>> https://github.com/apache/cloudstack/pull/1299
>> 
>> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
>> https://github.com/apache/cloudstack/pull/1298
>> 
>> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
>> https://github.com/apache/cloudstack/pull/1276
>> 
>> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
>> https://github.com/apache/cloudstack/pull/1277
>> 
>> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
>> https://github.com/apache/cloudstack/pull/1291
>> 
>> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
>> https://github.com/apache/cloudstack/pull/1296
>> 
>> 
>> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
>> 
>> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
>> 
>> 
>> Features:
>> =========
>> 
>> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
>> https://github.com/apache/cloudstack/pull/1297
>> 
>> #872 Strongswan vpn feature <== needs serious testing
>> https://github.com/apache/cloudstack/pull/872
>> 
>> Bug fixes:
>> ==========
>> 
>> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
>> https://github.com/apache/cloudstack/pull/1321
>> 
>> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
>> https://github.com/apache/cloudstack/pull/1309
>> 
>> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
>> https://github.com/apache/cloudstack/pull/1278
>> 
>> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
>> https://github.com/apache/cloudstack/pull/1272
>> 
>> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
>> https://github.com/apache/cloudstack/pull/1198
>> 
>> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
>> https://github.com/apache/cloudstack/pull/866/files
>> 
>> 
>> 
>> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
>> https://github.com/apache/cloudstack/pull/1289
>> 
>> 
>> 
>> 
>> 
> 
> 
> -- 
> Ron Wheeler
> President
> Artifact Software Inc
> email: rwheeler@artifact-software.com
> skype: ronaldmwheeler
> phone: 866-970-2435, ext 102
> 


Re: Pull Requests we should include in 4.7.1 / 4.8.0

Posted by Ron Wheeler <rw...@artifact-software.com>.
Are all of the documentation issues fixed?

Does the documentation reflect the 4.7.1/4.8 release?
Are there any new issues that need to be created to update the 
documentation?

Ron


On 10/01/2016 7:23 AM, Remi Bergsma wrote:
> Hi all,
>
> Below is a list of the PRs I'd like to suggest for our upcoming 4.7.1/4.8.0 releases. Please help review and test these. Lots of them already had some form of tesing/review so with little effort we might be able to get them in on time. The new features listed probably take a lot more time to test.
>
> Regards,
> Remi
>
>
> Easy to test/review UI fixes:
> =============================
>
> #1327 CLOUDSTACK-9220 Sort list of domains on Domain tab in UI
> https://github.com/apache/cloudstack/pull/1327
>
> #1325 CLOUDSTACK-9221 Allow admin to see user VMs on port forwarding page in UI
> https://github.com/apache/cloudstack/pull/1325
>
> #1301 CLOUDSTACK-9186: Root admin cannot see public ip in VPC created by Domain admin user in UI
> https://github.com/apache/cloudstack/pull/1301
>
> #1300 CLOUDSTACK-9192: UpdateVpnCustomerGateway is failing in UI
> https://github.com/apache/cloudstack/pull/1300
>
> VPN support for Sonicwall devices:
> ==================================
>
> #1317 [4.7] ADD Force UDP encapsulation option to Site2Site VPN
> https://github.com/apache/cloudstack/pull/1317
>
> VPC/router bug fixes:
> =====================
>
> #1318 CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
> https://github.com/apache/cloudstack/pull/1318
>
> #1299 CLOUDSTACK-6485 prevent ip asignment of private gw iface
> https://github.com/apache/cloudstack/pull/1299
>
> #1298 CLOUDSTACK-9204 Do not error when staticroute is already gone
> https://github.com/apache/cloudstack/pull/1298
>
> #1276 [4.7] FIX Site2SiteVPN on redundant VPC
> https://github.com/apache/cloudstack/pull/1276
>
> #1277 [4.7] Critical VPCVR issues fixed: CLOUDSTACK-9154; CLOUDSTACK-9187; and CLOUDSTACK-9188
> https://github.com/apache/cloudstack/pull/1277
>
> #1291 CLOUDSTACK-9202 Bump ssh timeout for VR commands
> https://github.com/apache/cloudstack/pull/1291
>
> #1296 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh
> https://github.com/apache/cloudstack/pull/1296
>
>
> I've tested all Pull Requests above and we are running them in production at SBP. I believe we should complete their reviews and make sure they are included in our next releases. Will save problems for users, for sure.
>
> Then I looked at the (long) list of other Pull Requests that seem interesting to include. Feel free to add your own, make sure it gets reviewed. Just ping me so I can merge.
>
>
> Features:
> =========
>
> #1297 CLOUDSTACK-9203 Implement security group move on updateVM API call
> https://github.com/apache/cloudstack/pull/1297
>
> #872 Strongswan vpn feature <== needs serious testing
> https://github.com/apache/cloudstack/pull/872
>
> Bug fixes:
> ==========
>
> #1321 CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged offerings when called with VM id
> https://github.com/apache/cloudstack/pull/1321
>
> #1309 CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
> https://github.com/apache/cloudstack/pull/1309
>
> #1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod
> https://github.com/apache/cloudstack/pull/1278
>
> #1272 CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up
> https://github.com/apache/cloudstack/pull/1272
>
> #1198 CLOUDSTACK-9114: restartnetwork with cleanup should restart the RVRs one by one
> https://github.com/apache/cloudstack/pull/1198
>
> #866 CLOUDSTACK-8751 minimise downtime of network when network update is in progress.
> https://github.com/apache/cloudstack/pull/866/files
>
>
>
> PS: Let's finally fix all the build failuers due to FindBugs (since Dec 2?):
> https://github.com/apache/cloudstack/pull/1289
>
>
>
>
>


-- 
Ron Wheeler
President
Artifact Software Inc
email: rwheeler@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102