You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/07/20 14:49:05 UTC
Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-21345
https://issues.apache.org/jira/browse/AMBARI-21345
Repository: ambari
Description
-------
Additional patch to solve naming issues
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 5180870
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4229d34
Diff: https://reviews.apache.org/r/60999/diff/1/
Testing
-------
Manual testing.
Thanks,
Dmytro Sen
Re: Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
Posted by Sid Wagle <sw...@hortonworks.com>.
> On July 20, 2017, 6:55 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3367 (patched)
> > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3367>
> >
> > Can you please add comments why we need to track this separately?
>
> Dmytro Sen wrote:
> For simpler maintenance.
I meant adding code comments.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/#review181074
-----------------------------------------------------------
On July 21, 2017, 11 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60999/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 11 a.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21345
> https://issues.apache.org/jira/browse/AMBARI-21345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Additional patch to solve naming issues
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 0b140e4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 44943c7
>
>
> Diff: https://reviews.apache.org/r/60999/diff/2/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3367 (patched)
> > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3367>
> >
> > Can you please add comments why we need to track this separately?
>
> Dmytro Sen wrote:
> For simpler maintenance.
>
> Sid Wagle wrote:
> I meant adding code comments.
It's in the code.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/#review181074
-----------------------------------------------------------
On Июль 21, 2017, 11 д.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60999/
> -----------------------------------------------------------
>
> (Updated Июль 21, 2017, 11 д.п.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21345
> https://issues.apache.org/jira/browse/AMBARI-21345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Additional patch to solve naming issues
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 0b140e4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 44943c7
>
>
> Diff: https://reviews.apache.org/r/60999/diff/2/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3367 (patched)
> > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3367>
> >
> > Can you please add comments why we need to track this separately?
For simpler maintenance.
> On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3661 (patched)
> > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3661>
> >
> > Can we call this something more meaningful than temp2 ?
Fixed.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/#review181074
-----------------------------------------------------------
On Июль 21, 2017, 11 д.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60999/
> -----------------------------------------------------------
>
> (Updated Июль 21, 2017, 11 д.п.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21345
> https://issues.apache.org/jira/browse/AMBARI-21345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Additional patch to solve naming issues
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 0b140e4
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 44943c7
>
>
> Diff: https://reviews.apache.org/r/60999/diff/2/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/#review181074
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Lines 3367 (patched)
<https://reviews.apache.org/r/60999/#comment256508>
Can you please add comments why we need to track this separately?
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Lines 3661 (patched)
<https://reviews.apache.org/r/60999/#comment256507>
Can we call this something more meaningful than temp2 ?
- Sid Wagle
On July 20, 2017, 2:49 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60999/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 2:49 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-21345
> https://issues.apache.org/jira/browse/AMBARI-21345
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Additional patch to solve naming issues
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 5180870
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4229d34
>
>
> Diff: https://reviews.apache.org/r/60999/diff/1/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 60999: Add host doesn't fully add a node when
include/exclude files are used
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60999/
-----------------------------------------------------------
(Updated Июль 21, 2017, 11 д.п.)
Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-21345
https://issues.apache.org/jira/browse/AMBARI-21345
Repository: ambari
Description
-------
Additional patch to solve naming issues
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 0b140e4
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 44943c7
Diff: https://reviews.apache.org/r/60999/diff/2/
Changes: https://reviews.apache.org/r/60999/diff/1-2/
Testing
-------
Manual testing.
Thanks,
Dmytro Sen