You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 10:02:33 UTC

[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.

jerpelea commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count.
URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r402896853
 
 

 ##########
 File path: netutils/dhcpc/dhcpc.c
 ##########
 @@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr,
 
       /* Configure for read timeouts */
 
-      tv.tv_sec  = 10;
+      tv.tv_sec  = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT;
 
 Review comment:
   is there are reason for changing the 10 second dely with 3?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services