You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/14 03:59:32 UTC
Review Request 37467: Fixed scheduler library to send calls in order.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37467/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-2552
https://issues.apache.org/jira/browse/MESOS-2552
Repository: mesos
Description
-------
Add a queue to guarantee that calls are delivered in order on the master. Ideally, http:post() would allow us to do pipelining on the same connection.
Diffs
-----
src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316
Diff: https://reviews.apache.org/r/37467/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 37467: Fixed scheduler library to send calls in
order.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37467/#review95370
-----------------------------------------------------------
Ship it!
LGTM !
Would we do a test run on Jenkins before committing this in just to be sure since the last time review bot did seem to show a false positive on r37328 ?
src/scheduler/scheduler.cpp (line 382)
<https://reviews.apache.org/r/37467/#comment150319>
Micro nit : How about just CHECK(!calls.empty()) ?
- Anand Mazumdar
On Aug. 14, 2015, 1:59 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37467/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 1:59 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-2552
> https://issues.apache.org/jira/browse/MESOS-2552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a queue to guarantee that calls are delivered in order on the master. Ideally, http:post() would allow us to do pipelining on the same connection.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp 3fbe3831cf93c29180bc7e433fd57c6108988316
>
> Diff: https://reviews.apache.org/r/37467/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>