You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/02/24 16:42:30 UTC
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/436
[FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-1607] Fixes failing JobManagerFailsITCase and SimpleRecoveryITCase
This PR contains fixes for the failing ```JobManagerFailsITCase``` and ```SimpleRecoveryITCase```.
In the wake of fixing these issues, I came across a livelock in the ```PartitionRequestClientFactory``` which is fixed as well.
Moreover, the way cached partition infos are treated has been corrected. In case of a job restart they are now discarded.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixJobManagerFailsITCase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/436.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #436
----
commit ee70fa7f6730ee6415e5cd1dcfcc7ebcb4fb8be1
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-20T11:34:19Z
[FLINK-1606] [tests] Fixes JobManagerFailsITCase for Akka 2.2.1 by setting gate-invalid-address-for = 5s and quarantine-systems-for = off
commit 9659d392391585f5ff84e67fd5a4a79f3d110fba
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-20T16:02:04Z
[FLINK-1607] [tests] Fixes SimpleRecoveryITCase by rebalancing the data sources so that all mappers receive at least one element
commit 534ebd39e8b0757f5a67f98b43f8d79d3ed02799
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-23T12:49:05Z
[FLINK-1604] [runtime] Fixes livelock in PartitionRequestClientFactory.createPartitionRequestClient
Replaces recursive concurrent modification resolution by while loop
Turns off stdout-logging of Akka. Sends proper exceptions in ErrorResponse.
Proper stream closing
commit 65e22a417c29efda650440c53c3fa0f3767bd9b9
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-02-24T11:41:35Z
[FLINK-1604] [FLINK-1568] Add initial connect failure test
commit 505cbecd005d712c25a47b64034a72a539cb1ea8
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-02-24T14:58:25Z
[FLINK-1607] [runtime] Moves PartialPartitionInfo from ExecutionVertex to Execution to automatically clear them in case of restart
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/436
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/436#issuecomment-75789360
+1
Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/436#issuecomment-75861629
W000t!
+1 @uce =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/436#discussion_r25302080
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartitionInfo.java ---
@@ -143,7 +147,14 @@ public static PartitionInfo fromEdge(ExecutionEdge edge, SimpleSlot consumerSlot
}
}
- return new PartitionInfo(partitionId, producerExecutionId, producerLocation, producerAddress);
+ PartitionInfo partitionInfo = new PartitionInfo(partitionId, producerExecutionId,
+ producerLocation, producerAddress);
+
+ if (LOG.isDebugEnabled()) {
--- End diff --
True, it's redundant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/436#issuecomment-75808232
I'll address @hsaputra's comment and merge this bad boy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1568] [FLINK-1604] [FLINK-1606] [FLINK-...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/436#discussion_r25268693
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartitionInfo.java ---
@@ -143,7 +147,14 @@ public static PartitionInfo fromEdge(ExecutionEdge edge, SimpleSlot consumerSlot
}
}
- return new PartitionInfo(partitionId, producerExecutionId, producerLocation, producerAddress);
+ PartitionInfo partitionInfo = new PartitionInfo(partitionId, producerExecutionId,
+ producerLocation, producerAddress);
+
+ if (LOG.isDebugEnabled()) {
--- End diff --
Just small nit, since we are now using SLF4J, we no longer need to do guard for simple debug logging [1]. Hopefully to get the code less busy =)
[1] http://slf4j.org/faq.html#logging_performance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---