You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/13 10:44:46 UTC
[GitHub] [incubator-mxnet] gilbertfrancois opened a new pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
gilbertfrancois opened a new pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344
Fix the direction of in_channels -> out_channels in the repr function for ConvTranspose classes.
Co-authored-by: g4b1nagy <ga...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] gilbertfrancois commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
gilbertfrancois commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707659832
I made a small test to show its new behaviour. Note that the test is done on gpu, because on cpu, only 1D or 2D Deconvolution is supported.
```
import mxnet as mx
ctx = mx.gpu(0)
x_1d = mx.nd.random.randn(1, 1, 8, ctx=ctx)
x_2d = mx.nd.random.randn(1, 1, 8, 8, ctx=ctx)
x_3d = mx.nd.random.randn(1, 1, 8, 8, 8, ctx=ctx)
conv = mx.gluon.nn.Conv1D(in_channels=1, channels=2, kernel_size=3, strides=1)
conv.initialize(ctx=ctx)
y_1d = conv(x_1d)
mx.nd.waitall()
print(conv)
assert x_1d.shape[1] == 1
assert y_1d.shape[1] == 2
conv_t = mx.gluon.nn.Conv1DTranspose(in_channels=1, channels=2, kernel_size=3, strides=1)
conv_t.initialize(ctx=ctx)
y_1d = conv_t(x_1d)
mx.nd.waitall()
print(conv_t)
assert x_1d.shape[1] == 1
assert y_1d.shape[1] == 2
conv = mx.gluon.nn.Conv2D(in_channels=1, channels=2, kernel_size=3, strides=1)
conv.initialize(ctx=ctx)
y_2d = conv(x_2d)
mx.nd.waitall()
print(conv)
assert x_2d.shape[1] == 1
assert y_2d.shape[1] == 2
assert "1 -> 2" in conv.__repr__()
conv_t = mx.gluon.nn.Conv2DTranspose(in_channels=1, channels=2, kernel_size=3, strides=1)
conv_t.initialize(ctx=ctx)
y_2d = conv_t(x_2d)
mx.nd.waitall()
print(conv_t)
assert x_2d.shape[1] == 1
assert y_2d.shape[1] == 2
assert "1 -> 2" in conv_t.__repr__()
conv = mx.gluon.nn.Conv3D(in_channels=1, channels=2, kernel_size=3, strides=1)
conv.initialize(ctx=ctx)
y_3d = conv(x_3d)
mx.nd.waitall()
assert x_3d.shape[1] == 1
assert y_3d.shape[1] == 2
print(conv)
conv_t = mx.gluon.nn.Conv3DTranspose(in_channels=1, channels=2, kernel_size=3, strides=1)
conv_t.initialize(ctx=ctx)
y_3d = conv_t(x_3d)
mx.nd.waitall()
assert x_3d.shape[1] == 1
assert y_3d.shape[1] == 2
print(conv_t)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-708079358
thanks for the fix @gilbertfrancois @g4b1nagy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707655739
Hey @gilbertfrancois , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, windows-cpu, centos-gpu, windows-gpu, unix-gpu, unix-cpu, miscellaneous, edge, website, clang, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu removed a comment on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
leezu removed a comment on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707911701
@gilbertfrancois would you like to add the test in the `tests/python/unittest/test_gluon.py` or similar file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707911701
@gilbertfrancois would you like to add the test in the `tests/python/unittest/test_gluon.py` or similar file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707911965
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19344: [BUGFIX] Fix ConvTranspose __repr__ (#19338)
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19344:
URL: https://github.com/apache/incubator-mxnet/pull/19344#issuecomment-707911919
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org