[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #196: HDDS-2516. Code cleanup in EventQueue

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #196: HDDS-2516. Code cleanup in EventQueue
URL: https://github.com/apache/hadoop-ozone/pull/196#discussion_r348201975
 
 

 ##########
 File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/Event.java
 ##########
 @@ -20,16 +20,16 @@
 /**
  * Identifier of an async event.
  *
- * @param <PAYLOAD> THe message payload type of this event.
+ * @param <P> THe message payload type of this event.
  */
-public interface Event<PAYLOAD> {
+public interface Event<P> {
 
 Review comment:
   Have you guys read the reasoning for this Rule. Sonar has rationale for each rule. From the rule book.
   
   "Shared naming conventions make it possible for a team to collaborate efficiently. Following the established convention of single-letter type parameter names helps users and maintainers of your code quickly see the difference between a type parameter and a poorly named class.
   
   This rule check that all type parameter names match a provided regular expression. The following code snippets use the default regular expression."
   
   It is basically saying that it wants a regular expression that matches a Type parameter, so people and tools get consistent experience. So if your rule is some like I need more chars but capital letter, then we need to spell out that rule. 
   
   From my own perspective; since I am very lazy, if someone else has a written a rule for me, it is far easier for me to follow; rather than think, debated and ultimately form a new rule. 
   
   So either one of you need to define the new rule -- for the TYPES in Java or let this be. I am open with either approach.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org