You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:52:41 UTC

[GitHub] [shardingsphere] jingshanglu commented on issue #8003: Discuss Merge StatementSQLVisitor into same one or use lots of minor visitor to handle SQL segment

jingshanglu commented on issue #8003:
URL: https://github.com/apache/shardingsphere/issues/8003#issuecomment-720872010


   @terrymanu The first way does make the class larger, but it brings the advantages of simple structure and easy reuse the visitor function. For readability, I think only one class is easier to read,  and no need to transform class to see the code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org