You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriram Subramanian <sr...@gmail.com> on 2014/02/24 10:59:54 UTC
Re: Review Request 15711: Patch for KAFKA-930
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15711/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 9:59 a.m.)
Review request for kafka.
Bugs: KAFKA-930
https://issues.apache.org/jira/browse/KAFKA-930
Repository: kafka
Description (updated)
-------
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
Conflicts:
core/src/main/scala/kafka/controller/KafkaController.scala
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
Conflicts:
core/src/main/scala/kafka/controller/KafkaController.scala
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
some more changes
use zk for auto rebalance
Address code review feedbacks
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
commit missing code
some more changes
fix merge conflicts
Add auto leader rebalance support
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
Conflicts:
core/src/main/scala/kafka/admin/AdminUtils.scala
core/src/main/scala/kafka/admin/TopicCommand.scala
change comments
commit the remaining changes
Move AddPartitions into TopicCommand
Diffs (updated)
-----
core/src/main/scala/kafka/controller/KafkaController.scala 00a1f9802474a688fe725db8d6bff493ede48684
Diff: https://reviews.apache.org/r/15711/diff/
Testing
-------
Thanks,
Sriram Subramanian
Re: Review Request 15711: Patch for KAFKA-930
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15711/#review35281
-----------------------------------------------------------
Ship it!
Just the following minor comment.
core/src/main/scala/kafka/controller/KafkaController.scala
<https://reviews.apache.org/r/15711/#comment65733>
Just checking isTopicQueuedUpForDeletion() is enough. It will always return true until the topic deletion completes.
- Jun Rao
On Feb. 24, 2014, 9:59 a.m., Sriram Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15711/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 9:59 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-930
> https://issues.apache.org/jira/browse/KAFKA-930
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
> Conflicts:
> core/src/main/scala/kafka/controller/KafkaController.scala
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
> Conflicts:
> core/src/main/scala/kafka/controller/KafkaController.scala
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> some more changes
>
>
> use zk for auto rebalance
>
>
> Address code review feedbacks
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> commit missing code
>
>
> some more changes
>
>
> fix merge conflicts
>
>
> Add auto leader rebalance support
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
>
> Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
>
> Conflicts:
> core/src/main/scala/kafka/admin/AdminUtils.scala
> core/src/main/scala/kafka/admin/TopicCommand.scala
>
> change comments
>
>
> commit the remaining changes
>
>
> Move AddPartitions into TopicCommand
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala 00a1f9802474a688fe725db8d6bff493ede48684
>
> Diff: https://reviews.apache.org/r/15711/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriram Subramanian
>
>