[GitHub] [apisix] spacewander commented on a change in pull request #5934: feat: support to use path parameter with plugin's control api

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #5934:
URL: https://github.com/apache/apisix/pull/5934#discussion_r775692273



##########
File path: apisix/control/router.lua
##########
@@ -95,6 +96,14 @@ do
 function fetch_control_api_router()
     core.table.clear(routes)
 
+    local with_parameter = false
+    local conf = core.config.local_conf()
+    if conf.apisix.enable_control and conf.apisix.control then

Review comment:
       Could you move this block to the end of the function?
   Also, we can save `conf.apisix.enable_control and ` as control API must be enabled if we hit this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org