You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "wklken (via GitHub)" <gi...@apache.org> on 2023/11/28 13:16:47 UTC
[PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
wklken opened a new pull request, #10561:
URL: https://github.com/apache/apisix/pull/10561
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes #10555
the `resty/radixtree.lua` require a encoded uri for matching, while we pass a decoded uri, which will cause 404 if the `parameter` in path contains characters need to be encoded!
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "wklken (via GitHub)" <gi...@apache.org>.
wklken commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1408610709
##########
t/router/radixtree-uri-with-parameter-encoded.t:
##########
@@ -0,0 +1,89 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+worker_connections(256);
+no_root_location();
+no_shuffle();
+
+our $yaml_config = <<_EOC_;
+apisix:
+ node_listen: 1984
+ router:
+ http: 'radixtree_uri_with_parameter'
+_EOC_
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if (!$block->yaml_config) {
+ $block->set_value("yaml_config", $yaml_config);
+ }
+});
+
+run_tests();
+
+__DATA__
+
+
+=== TEST 1: set route(id: 1)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "methods": ["GET"],
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "plugins": {
+ "proxy-rewrite":{"uri":"/hello"}
+ },
+ "uri": "/name/:name/bar"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+=== TEST 1: hit routes
Review Comment:
before encode the uri: TEST 1 pass, TEST 2 failed
after encode the uri: TEST 1 pass, TEST 2 pass
the first case is for the uri which don't need to be encoded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436199408
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
We can't modify like this, it will cause another problem, let me show you an example
```
=== TEST 1: set route(id: 1)
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
local code, body = t('/apisix/admin/routes/1',
ngx.HTTP_PUT,
[[{
"methods": ["GET"],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
},
"uris": ["/hello","/hello1","/中文"]
}]]
)
if code >= 300 then
ngx.status = code
end
ngx.say(body)
}
}
--- request
GET /t
--- response_body
passed
=== TEST 2: hit routes1
--- request
GET /中文
--- response_body
hello world
```
The non-ascii uri will hit successfully before your change, but fails after your change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436199408
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
We can't modify like this, let me show you an example
```
=== TEST 1: set route(id: 1)
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
local code, body = t('/apisix/admin/routes/1',
ngx.HTTP_PUT,
[[{
"methods": ["GET"],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
},
"uris": ["/hello","/hello1","/中文"]
}]]
)
if code >= 300 then
ngx.status = code
end
ngx.say(body)
}
}
--- request
GET /t
--- response_body
passed
=== TEST 2: hit routes1
--- request
GET /中文
--- response_body
hello world
```
The non-ascii uri will hit successfully before your change, but fails after your change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10561:
URL: https://github.com/apache/apisix/pull/10561#issuecomment-1838115143
Thanks for your contribution, i will check this later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "wklken (via GitHub)" <gi...@apache.org>.
wklken commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1410241036
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
only encode the uri if router is `radixtree_uri_with_parameter`? or it's better the `lua-resty-radixtree` do the uri encode, while it has the `global_opts.no_param_match` and claim the `res[i] = [=[([\w\-_;:@&=!',\%\$\.\+\*\(\)]+)]=]`?
and we need a func to check if the uri contains any non-ASCII character
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "Vacant2333 (via GitHub)" <gi...@apache.org>.
Vacant2333 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1408052495
##########
t/router/radixtree-uri-with-parameter-encoded.t:
##########
@@ -0,0 +1,89 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+worker_connections(256);
+no_root_location();
+no_shuffle();
+
+our $yaml_config = <<_EOC_;
+apisix:
+ node_listen: 1984
+ router:
+ http: 'radixtree_uri_with_parameter'
+_EOC_
+
+add_block_preprocessor(sub {
+ my ($block) = @_;
+
+ if (!$block->yaml_config) {
+ $block->set_value("yaml_config", $yaml_config);
+ }
+});
+
+run_tests();
+
+__DATA__
+
+
+=== TEST 1: set route(id: 1)
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "methods": ["GET"],
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "plugins": {
+ "proxy-rewrite":{"uri":"/hello"}
+ },
+ "uri": "/name/:name/bar"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.say(body)
+ }
+ }
+--- request
+GET /t
+--- response_body
+passed
+
+
+=== TEST 1: hit routes
Review Comment:
im not sure that if we need this test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436199408
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
We can't modify like this, it will cause another problem, let me show you an example
```
=== TEST 1: set route(id: 1)
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
local code, body = t('/apisix/admin/routes/1',
ngx.HTTP_PUT,
[[{
"methods": ["GET"],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
},
"uris": ["/hello","/hello1","/中文"]
}]]
)
if code >= 300 then
ngx.status = code
end
ngx.say(body)
}
}
--- request
GET /t
--- response_body
passed
=== TEST 2: hit routes1
--- request
GET /中文
--- response_body
hello world
```
The non-ascii uri will hit the route successfully before your change, but fails after your change.
So the lua-resty-radixtree library need the decoded uri to match the route, but forget to handle the parameter part.
We should take a look at the lua-resty-radixtree library instead of just encoding the uri
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 closed pull request #10561: fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match
URL: https://github.com/apache/apisix/pull/10561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436199408
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
We can't modify like this, it will cause another problem, let me show you an example
```
=== TEST 1: set route(id: 1)
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
local code, body = t('/apisix/admin/routes/1',
ngx.HTTP_PUT,
[[{
"methods": ["GET"],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
},
"uris": ["/hello","/hello1","/中文"]
}]]
)
if code >= 300 then
ngx.status = code
end
ngx.say(body)
}
}
--- request
GET /t
--- response_body
passed
=== TEST 2: hit routes1
--- request
GET /中文
--- response_body
hello world
```
The non-ascii uri will hit the route successfully before your change, but fails after your change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436199408
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
We can't modify like this, it will cause another problem, let me show you an example
```
=== TEST 1: set route(id: 1)
--- config
location /t {
content_by_lua_block {
local t = require("lib.test_admin").test
local code, body = t('/apisix/admin/routes/1',
ngx.HTTP_PUT,
[[{
"methods": ["GET"],
"upstream": {
"nodes": {
"127.0.0.1:1980": 1
},
"type": "roundrobin"
},
"uris": ["/hello","/hello1","/中文"]
}]]
)
if code >= 300 then
ngx.status = code
end
ngx.say(body)
}
}
--- request
GET /t
--- response_body
passed
=== TEST 2: hit routes1
--- request
GET /中文
--- response_body
hello world
```
The non-ascii uri will hit the route successfully before your change, but fails after your change.
So the lua-resty-radixtree library need the decoded uri to match the route, but forget to handle the parameter part.
We should take a look at the lua-resty-radixtree instead of just encoding the uri
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436123697
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
@wklken what happens if uri contains non-ascii characters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1410190997
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
I have two concerns:
1. In the `radixtree_uri` matching mode, the `core.utils.uri_safe_encode` function will also be run, but it actually has no effect.
2. The probability that the uri parameter contains non-ASCII characters is low. Is there a more efficient way to solve this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436123697
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
@wklken what happens if uri in addition to the parameter part contains non-ascii characters ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436123697
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
@wklken what happens if uri contains non-ascii characters in addition to the parameter part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "wklken (via GitHub)" <gi...@apache.org>.
wklken commented on code in PR #10561:
URL: https://github.com/apache/apisix/pull/10561#discussion_r1436225096
##########
apisix/http/route.lua:
##########
@@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx)
match_opts.vars = api_ctx.var
match_opts.matched = core.tablepool.fetch("matched_route_record", 0, 4)
- local ok = uri_router:dispatch(api_ctx.var.uri, match_opts, api_ctx, match_opts)
+ local encoded_uri = core.utils.uri_safe_encode(api_ctx.var.uri)
Review Comment:
agree, the lua-resty-radixtree library should fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #10561:
URL: https://github.com/apache/apisix/pull/10561#issuecomment-1869287303
@wklken I will close this pr, looking forward to your fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org