You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/14 07:01:23 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
bgawrych opened a new pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708
## Description ##
Backport of two changes:
- Fix softmax, logsoftmax failed on empty ndarray (#18602)
- fix npx.softmax for 0-sized inputs (#18158)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-661706693
@mxnet-bot run ci [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv merged pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
TaoLv merged pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-663596050
@bgawrych I'm rebasing your branch to the latest of v1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-666974960
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-667830478
Jenkins CI successfully triggered : [edge, centos-gpu, sanity, unix-gpu, clang, centos-cpu, unix-cpu, miscellaneous, website, windows-gpu, windows-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-667981907
@TaoLv @PatricZhao I think that the problem with out of date branch is solved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-664794961
Jenkins CI successfully triggered : [website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-666241463
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-667830425
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-662852190
@mxnet-bot run ci [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-668050049
@bgawrych Thanks. Now it's merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-658007738
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, unix-gpu, windows-gpu, edge, centos-gpu, miscellaneous, website, sanity, unix-cpu, centos-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-666975045
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-666241371
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-665047240
Not sure what's the merge policy of v1.x. Github keeps saying this branch is out of date w ith the base branch so we cannot merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-664794915
@mxnet-bot run ci [website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-662950170
@TaoLv @PatricZhao Can you take a look?
CC: @Yiyan66 as owner of the fix npx.softmax for 0-sized inputs (#18158)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-661706741
Jenkins CI successfully triggered : [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18708: [v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18708:
URL: https://github.com/apache/incubator-mxnet/pull/18708#issuecomment-662852213
Jenkins CI successfully triggered : [edge, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org