You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/07/13 20:47:08 UTC
[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic
Hello Attila Bukor, Kudu Jenkins, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10945
to review the following change.
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic
......................................................................
KUDU-2312: Scan predicate application ordering is non-deterministic
This changes the scan predicate evaluation ordering so that it primarily
orders by selectivity (as before), but breaks ties by column index.
Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Reviewed-on: http://gerrit.cloudera.org:8080/9440
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/tablet/cfile_set.h
4 files changed, 111 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/10945/1
--
To view, visit http://gerrit.cloudera.org:8080/10945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10945 )
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic
......................................................................
KUDU-2312: Scan predicate application ordering is non-deterministic
This changes the scan predicate evaluation ordering so that it primarily
orders by selectivity (as before), but breaks ties by column index.
Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Reviewed-on: http://gerrit.cloudera.org:8080/9440
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/10945
---
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/tablet/cfile_set.h
4 files changed, 111 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10945 )
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 22:08:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10945 )
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic
......................................................................
Patch Set 1:
This applied cleanly except for the release_notes.adoc change, which I stripped.
--
To view, visit http://gerrit.cloudera.org:8080/10945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348
Gerrit-Change-Number: 10945
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 13 Jul 2018 20:47:31 +0000
Gerrit-HasComments: No