[jira] [Comment Edited] (ZOOKEEPER-2464) NullPointerException on ContainerManager

["Edward Ribeiro (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836766#comment-15836766 ] 

Edward Ribeiro edited comment on ZOOKEEPER-2464 at 1/25/17 9:54 AM:
--------------------------------------------------------------------

+1, LGTM.

Hey, [~randgalt], I have just seen that ZK projects imports mockito framework but only uses it on a single test case (as far as my quick-and-dirty search showed).

*If you want to add a test case to this bug*, then I am attaching a class that can be uses mockito to do so. If you decide it's too much boilerplate for little benefit then no problem leaving it out of this patch. *It's up to you to include it or not, just an idea*. :)

In either case, we are good to go with this patch, IMHO. Please, any committer would mind to merge it as soon as possible?

/cc [~hanm], [~arshadmohammad]?


was (Author: eribeiro):
+1, lgtm. Hey, [~randgalt], I have just seen that ZK projects imports mockito framework but only uses it on a single test case (as far as my quick-and-dirty search showed).

*If you want to add a test case to this bug*, then I am attaching a class that can be uses mockito to do so. If you decide it's too much boilerplate for little benefit then no problem leaving it out of this patch. *It's up to you to include it or not, just an idea*. :)

In either case, we are good to go with this patch, IMHO. Please, any committer would mind to merge it as soon as possible?

/cc [~hanm], [~arshadmohammad]?

> NullPointerException on ContainerManager
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2464
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2464
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.1
>            Reporter: Stefano Salmaso
>            Assignee: Jordan Zimmerman
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ContainerManagerTest.java, ZOOKEEPER-2464.patch
>
>
> I would like to expose you to a problem that we are experiencing.
> We are using a cluster of 7 zookeeper and we use them to implement a distributed lock using Curator (http://curator.apache.org/curator-recipes/shared-reentrant-lock.html)
> So .. we tried to play with the servers to see if everything worked properly and we stopped and start servers to see that the system worked well
> (like stop 03, stop 05, stop 06, start 05, start 06, start 03)
> We saw a strange behavior.
> The number of znodes grew up without stopping (normally we had 4000 or 5000, we got to 60,000 and then we stopped our application)
> In zookeeeper logs I saw this (on leader only, one every minute)
> 2016-07-04 14:53:50,302 [myid:7] - ERROR [ContainerManagerTask:ContainerManager$1@84] - Error checking containers
> java.lang.NullPointerException
>        at org.apache.zookeeper.server.ContainerManager.getCandidates(ContainerManager.java:151)
>        at org.apache.zookeeper.server.ContainerManager.checkContainers(ContainerManager.java:111)
>        at org.apache.zookeeper.server.ContainerManager$1.run(ContainerManager.java:78)
>        at java.util.TimerThread.mainLoop(Timer.java:555)
>        at java.util.TimerThread.run(Timer.java:505)
> We have not yet deleted the data ... so the problem can be reproduced on our servers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)