You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/10 08:58:51 UTC

[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803439528



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -267,18 +267,31 @@ private void registerCallback() {
 
     @Override
     public void write(InputT element, Context context) throws IOException, InterruptedException {
+        while (mailboxExecutor.tryYield()) {}

Review comment:
       This seems weird 🤔 If I understand it correctly in means something along the lines of ... don't write results until we have anything else to do, so for example if user has a super frequent checkpointing (edge case), we can not make progress?
   
   @pnowojski Can you please verify?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org