You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/14 07:44:02 UTC
[GitHub] [geode] mkevo commented on a change in pull request #5248: GEODE-8247: modified FilterRoutingInfo checks
mkevo commented on a change in pull request #5248:
URL: https://github.com/apache/geode/pull/5248#discussion_r439801370
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
Review comment:
Please change names, e.g. onEventCalls -> **onEventCreateCalls**, onEventUPDATE -> **onEventUpdateCalls**
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
Review comment:
remove blank line
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
+ }
+
+ @Override
+ public void close() {
+
Review comment:
remove blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org