You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/12 04:06:03 UTC
[GitHub] [spark] zwangsheng opened a new pull request #33718: [CORE] modify exit executor log logic
zwangsheng opened a new pull request #33718:
URL: https://github.com/apache/spark/pull/33718
### What changes were proposed in this pull request?
Adjust the log logic of CoarseGrainedExecutorBackend
### Why are the changes needed?
When exit executor with system code 0, coarseGrainedExecutorBackend will print ERROR log.
That doesn't make sense, because it seems to me that executor's normal decommission is not caused by an exception.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33718: [CORE] modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897368348
can you file a JIRA please? Also it would be great to show the console output you got from the manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898412079
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898417387
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zwangsheng commented on pull request #33718: [CORE] modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897368922
> can you file a JIRA please? Also it would be great to show the console output you got from the manual test.
OK, i will do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898464777
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142427/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33718: [CORE] modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897334405
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897334405
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898389927
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898353893
**[Test build #142427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142427/testReport)** for PR 33718 at commit [`357ba65`](https://github.com/apache/spark/commit/357ba6563adc4ca64af87f20da12a33fad0f217d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zwangsheng commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897517170
Please take a check, thank you. @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zwangsheng commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
zwangsheng commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-897516113
Write a unit tests to reflect exitExecutor method

Using code 0 can print info log

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #33718:
URL: https://github.com/apache/spark/pull/33718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898393231
Strictly speaking, I think this should be a user-facing change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898590033
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898417387
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898353893
**[Test build #142427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142427/testReport)** for PR 33718 at commit [`357ba65`](https://github.com/apache/spark/commit/357ba6563adc4ca64af87f20da12a33fad0f217d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898345833
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33718: [SPARK-36487][CORE] Modify exit executor log logic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33718:
URL: https://github.com/apache/spark/pull/33718#issuecomment-898463352
**[Test build #142427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142427/testReport)** for PR 33718 at commit [`357ba65`](https://github.com/apache/spark/commit/357ba6563adc4ca64af87f20da12a33fad0f217d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org