[GitHub] shaofengshi closed pull request #396: KYLIN-3721 modify sourceCacheKey for RDBMS

[GitBox <gi...@apache.org>]

shaofengshi closed pull request #396: KYLIN-3721 modify sourceCacheKey for RDBMS
URL: https://github.com/apache/kylin/pull/396
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core-metadata/src/main/java/org/apache/kylin/source/SourceManager.java b/core-metadata/src/main/java/org/apache/kylin/source/SourceManager.java
index 03559bc370..c0bd3228ec 100644
--- a/core-metadata/src/main/java/org/apache/kylin/source/SourceManager.java
+++ b/core-metadata/src/main/java/org/apache/kylin/source/SourceManager.java
@@ -103,9 +103,10 @@ private String createSourceCacheKey(ISourceAware aware) {
         builder.append(config.getJdbcSourceConnectionUrl()).append('|');
         builder.append(config.getJdbcSourceDriver()).append('|');
         builder.append(config.getJdbcSourceUser()).append('|');
+        builder.append(config.getJdbcSourcePass()).append('|'); // In case password is wrong at the first time
         builder.append(config.getJdbcSourceFieldDelimiter()).append('|');
         builder.append(config.getJdbcSourceDialect()).append('|');
-        return builder.toString(); // jdbc password not needed, because url+user should be identical.
+        return builder.toString();
     }
 
     private ISource createSource(ISourceAware aware) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services