You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/21 18:45:38 UTC

[GitHub] [nifi] thenatog commented on issue #3916: NIFI-5481 Additional Sensitive Property Providers (#3)

thenatog commented on issue #3916: NIFI-5481 Additional Sensitive Property Providers (#3)
URL: https://github.com/apache/nifi/pull/3916#issuecomment-576822964
 
 
   I am still reviewing this PR, but as others said above I also had errors:
   
   * There were compilation errors as a result of building with Java 8. I set to build with Java 11 instead, however it should be backwards compatible so some changes will need to be made.
   * Small issue with javadoc for loadKeyStore() in HadoopCredentialsSensitivePropertyProvider.java:184.
   * Had issues with RAT (contrib-check) check on the password files password.sidefile and bad-password.sidefile in nifi-properties-loader. I added a RAT exclude to nifi-properties-loader/pom.xml
   * Issue with grpc dependency conflict, the nifi-properties-loader added dependency google-cloud-kms which included its own grpc. Had to exclude it from the google-cloud-kms dependency in the pom.
   
   I can submit these fixes for merging, but the Java 8 compatibility still needs to be looked at.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services