You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/05/12 22:36:06 UTC
[GitHub] couchdb-fauxton pull request: fix deleteDatabaseModal test
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/409
fix deleteDatabaseModal test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton tests---fix-some-nightwatch-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #409
----
commit f6681dfb6b76c1bd43a5edfb86822938b0bff6b3
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-05-12T20:17:52Z
fix deleteDatabaseModal test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/409#issuecomment-102196591
:D yay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/409#discussion_r30373446
--- Diff: app/addons/fauxton/base.js ---
@@ -104,7 +104,7 @@ function (app, FauxtonAPI, Components, NavbarReactComponents, NavigationActions,
Fauxton.Notification = FauxtonAPI.View.extend({
animationTimer: 5000,
-
+ id: 'global-notification-id',
--- End diff --
for what is that used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/409#discussion_r30375421
--- Diff: app/addons/fauxton/base.js ---
@@ -104,7 +104,7 @@ function (app, FauxtonAPI, Components, NavbarReactComponents, NavigationActions,
Fauxton.Notification = FauxtonAPI.View.extend({
animationTimer: 5000,
-
+ id: 'global-notification-id',
--- End diff --
it adds an id to an element without an id
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/409#issuecomment-102196463
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix nightwatch tests
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/409#discussion_r30375747
--- Diff: app/addons/fauxton/base.js ---
@@ -104,7 +104,7 @@ function (app, FauxtonAPI, Components, NavbarReactComponents, NavigationActions,
Fauxton.Notification = FauxtonAPI.View.extend({
animationTimer: 5000,
-
+ id: 'global-notification-id',
--- End diff --
Meaning, there are several nested elements inside the global notifications banner. All without IDs. This add one ID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---