You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by li...@apache.org on 2020/09/30 10:01:55 UTC

[submarine] branch master updated: SUBMARINE-642. Install latest python sdk in notebook

This is an automated email from the ASF dual-hosted git repository.

liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new b0602b1  SUBMARINE-642. Install latest python sdk in notebook
b0602b1 is described below

commit b0602b19961838eb0afe7ad02dd1253913412834
Author: Kevin Su <pi...@gmail.com>
AuthorDate: Tue Sep 29 11:15:57 2020 +0800

    SUBMARINE-642. Install latest python sdk in notebook
    
    ### What is this PR for?
    https://github.com/apache/submarine/blob/b2d3eed82b678c3243079fc25e6b47d44c28c841/dev-support/docker-images/jupyter/Dockerfile#L95
    
    Instead of install a stable version of pysubmarine, we should Install the latest pysubmarine in docker file, so that every time we manually build apache/submarine:jupyter-notebook-0.x.0-SNAPSHOT, we could use the latest version of pysubmarine
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-642
    
    ### How should this be tested?
    https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/731157706
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Kevin Su <pi...@gmail.com>
    
    Closes #417 from pingsutw/jupyter and squashes the following commits:
    
    1544d56 [Kevin Su] Update sdk
---
 dev-support/docker-images/jupyter/Dockerfile | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/dev-support/docker-images/jupyter/Dockerfile b/dev-support/docker-images/jupyter/Dockerfile
index 39267d9..983bcce 100644
--- a/dev-support/docker-images/jupyter/Dockerfile
+++ b/dev-support/docker-images/jupyter/Dockerfile
@@ -29,7 +29,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -yq --no-in
     build-essential \
     curl \
     wget \
-    vim \
+    git \
     bzip2 \
     ca-certificates \
     sudo \
@@ -91,8 +91,13 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
     conda clean --all -f -y && \
     rm -rf /home/$NB_USER/.cache/yarn
 
-# Install sumbarine python sdk and notebook
-RUN pip --quiet --no-cache-dir install notebook==6.1.3 apache-submarine
+# Install latest sumbarine python sdk and notebook
+RUN pip install notebook==6.1.3 && \
+    git clone https://github.com/apache/submarine && \
+    pip install submarine/submarine-sdk/pysubmarine && \
+    rm submarine -rf
+
+
 
 EXPOSE $NB_PORT
 ENTRYPOINT ["tini", "-g", "--"]


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org