You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/12/05 16:23:17 UTC

[GitHub] carbondata pull request #1606: [CARBONDATA-1839] [DataLoad]Fix bugs in compr...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1606#discussion_r154999120
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/ParallelReadMergeSorterImpl.java ---
    @@ -80,11 +81,7 @@ public void initialize(SortParameters sortParameters) {
             File.separator, CarbonCommonConstants.SORT_TEMP_FILE_LOCATION);
         finalMerger =
             new SingleThreadFinalSortFilesMerger(dataFolderLocations, sortParameters.getTableName(),
    -            sortParameters.getDimColCount(),
    -            sortParameters.getComplexDimColCount(), sortParameters.getMeasureColCount(),
    -            sortParameters.getNoDictionaryCount(), sortParameters.getMeasureDataType(),
    -            sortParameters.getNoDictionaryDimnesionColumn(),
    -            sortParameters.getNoDictionarySortColumn());
    +            new TableFieldStat(sortParameters));
    --- End diff --
    
    I think the indentation is not correct


---