You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Konrad Garus (Created) (JIRA)" <ji...@apache.org> on 2012/02/14 12:14:59 UTC
[jira] [Created] (TILES-542) Inject VelocityEngine into
VelocityAttributeRenderer
Inject VelocityEngine into VelocityAttributeRenderer
-----------------------------------------------------
Key: TILES-542
URL: https://issues.apache.org/jira/browse/TILES-542
Project: Tiles
Issue Type: Improvement
Components: tiles-velocity
Affects Versions: 2.2.2
Reporter: Konrad Garus
Priority: Minor
VelocityAttributeRenderer instantiates VelocityView, which in turn instantiates its own VelocityEngine. There is no way to inject a customized VelocityEngine from outside except for extending VelocityAttributeRenderer and overriding commit().
There should be an API for passing customized VelocityEngine to the view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TILES-542) Inject VelocityEngine into
VelocityAttributeRenderer
Posted by "Konrad Garus (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207638#comment-13207638 ]
Konrad Garus commented on TILES-542:
------------------------------------
The VelocityAttributeRenderer.params map on supports String values, so it is unsuitable. It could be solved by making this Map<String, Object> and adding a parameter for the custom engine, or by adding a VelocityEngine field to VelocityAttributeRenderer and passing it to the view in commit().
If this is confirmed and desired extension, I could submit a patch.
> Inject VelocityEngine into VelocityAttributeRenderer
> -----------------------------------------------------
>
> Key: TILES-542
> URL: https://issues.apache.org/jira/browse/TILES-542
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-velocity
> Affects Versions: 2.2.2
> Reporter: Konrad Garus
> Priority: Minor
>
> VelocityAttributeRenderer instantiates VelocityView, which in turn instantiates its own VelocityEngine. There is no way to inject a customized VelocityEngine from outside except for extending VelocityAttributeRenderer and overriding commit().
> There should be an API for passing customized VelocityEngine to the view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TILES-542) Inject VelocityEngine into
VelocityAttributeRenderer
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264612#comment-13264612 ]
Mck SembWever commented on TILES-542:
-------------------------------------
New development isn't planned for tiles-2.2
If this issue is still valid against tiles-3.0 (specifically tiles-request-velocity and tiles-velocity) then we would be interested in reviewing a patch.
> Inject VelocityEngine into VelocityAttributeRenderer
> -----------------------------------------------------
>
> Key: TILES-542
> URL: https://issues.apache.org/jira/browse/TILES-542
> Project: Tiles
> Issue Type: Improvement
> Components: tiles-velocity
> Affects Versions: 2.2.2
> Reporter: Konrad Garus
> Priority: Minor
>
> VelocityAttributeRenderer instantiates VelocityView, which in turn instantiates its own VelocityEngine. There is no way to inject a customized VelocityEngine from outside except for extending VelocityAttributeRenderer and overriding commit().
> There should be an API for passing customized VelocityEngine to the view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira