You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/28 18:18:10 UTC
[GitHub] [tvm] comaniac commented on a change in pull request #8161: [VM] Avoid round-trip Target->str->Target conversions
comaniac commented on a change in pull request #8161:
URL: https://github.com/apache/tvm/pull/8161#discussion_r641731595
##########
File path: python/tvm/relay/backend/vm.py
##########
@@ -198,20 +198,29 @@ def _update_target(self, target):
target = target if target else tvm.target.Target.current()
if target is None:
raise ValueError("Target is not set in env or passed as argument.")
- tgts = {}
- if isinstance(target, (str, tvm.target.Target)):
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(str(target)).device_type)
- tgts[dev_type] = tvm.target.Target(target)
- elif isinstance(target, dict):
- for dev, tgt in target.items():
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(dev).device_type)
- tgts[dev_type] = tvm.target.Target(tgt)
- else:
+
+ elif isinstance(target, str):
+ target = {target: target}
+
+ elif isinstance(target, tvm.target.Target):
+ target = {target.kind.name: target}
+
Review comment:
remove this line
##########
File path: python/tvm/relay/backend/vm.py
##########
@@ -198,20 +198,29 @@ def _update_target(self, target):
target = target if target else tvm.target.Target.current()
if target is None:
raise ValueError("Target is not set in env or passed as argument.")
- tgts = {}
- if isinstance(target, (str, tvm.target.Target)):
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(str(target)).device_type)
- tgts[dev_type] = tvm.target.Target(target)
- elif isinstance(target, dict):
- for dev, tgt in target.items():
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(dev).device_type)
- tgts[dev_type] = tvm.target.Target(tgt)
- else:
+
+ elif isinstance(target, str):
+ target = {target: target}
+
Review comment:
remove this line
##########
File path: python/tvm/relay/backend/vm.py
##########
@@ -198,20 +198,29 @@ def _update_target(self, target):
target = target if target else tvm.target.Target.current()
if target is None:
raise ValueError("Target is not set in env or passed as argument.")
- tgts = {}
- if isinstance(target, (str, tvm.target.Target)):
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(str(target)).device_type)
- tgts[dev_type] = tvm.target.Target(target)
- elif isinstance(target, dict):
- for dev, tgt in target.items():
- dev_type = tvm.tir.IntImm("int32", tvm.nd.device(dev).device_type)
- tgts[dev_type] = tvm.target.Target(tgt)
- else:
+
+ elif isinstance(target, str):
+ target = {target: target}
+
+ elif isinstance(target, tvm.target.Target):
+ target = {target.kind.name: target}
+
+ elif not isinstance(target, dict):
raise TypeError(
"target is expected to be str, tvm.target.Target, "
+ "or dict of str to str/tvm.target.Target, but received "
+ "{}".format(type(target))
)
+
+ tgts = {}
+
Review comment:
remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org