[GitHub] spark pull request #12913: [SPARK-928][CORE] Add support for Unsafe-based se...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12913#discussion_r73431033
  
    --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
    @@ -399,6 +399,14 @@ class KryoSerializerSuite extends SparkFunSuite with SharedSparkContext {
         assert(!ser2.getAutoReset)
       }
     
    +  private def testBothUnsafeAndSafe(f: SparkConf => Unit): Unit = {
    --- End diff --
    
    At first glance I don't see this function used anywhere I'm assuming this was meant to wrap some of the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org