[GitHub] [spark] dbtsai commented on a change in pull request #32033: [SPARK-34939][CORE] Throw fetch failure exception when unable to deserialize broadcasted map statuses

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #32033:
URL: https://github.com/apache/spark/pull/32033#discussion_r606122022



##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -843,7 +843,13 @@ private[spark] class MapOutputTrackerWorker(conf: SparkConf) extends MapOutputTr
         if (fetchedStatuses == null) {
           logInfo("Doing the fetch; tracker endpoint = " + trackerEndpoint)
           val fetchedBytes = askTracker[Array[Byte]](GetMapOutputStatuses(shuffleId))
-          fetchedStatuses = MapOutputTracker.deserializeMapStatuses(fetchedBytes, conf)
+          try {
+            fetchedStatuses = MapOutputTracker.deserializeMapStatuses(fetchedBytes, conf)
+          } catch {
+            case e: SparkException =>

Review comment:
       The failure could be `DIRECT`, how can you ensure it's only catching exception from broadcast?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org