You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:36:58 UTC
[GitHub] [hbase] saintstack commented on a change in pull request #1865: HBASE-24117 Shutdown AssignmentManager before ProcedureExecutor may c…
saintstack commented on a change in pull request #1865:
URL: https://github.com/apache/hbase/pull/1865#discussion_r437059050
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1530,6 +1530,11 @@ protected void stopServiceThreads() {
LOG.debug("Stopping service threads");
+ // stop procedure executor priority to other services such as server manager and assignment
Review comment:
Is this a synchronous call?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1530,6 +1530,11 @@ protected void stopServiceThreads() {
LOG.debug("Stopping service threads");
+ // stop procedure executor priority to other services such as server manager and assignment
Review comment:
Do you mean 'prior to other services'; i.e. before? If so, s/priority/prior/.
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -485,6 +486,12 @@ private void assignRegions(MasterProcedureEnv env, List<RegionInfo> regions) thr
// UPDATE: HBCKServerCrashProcedure overrides isMatchingRegionLocation; this check can get
// in the way of our clearing out 'Unknown Servers'.
if (!isMatchingRegionLocation(regionNode)) {
+ // See HBASE-24117, though we have already changed the shutdown order, it is still worth
+ // double checking here to confirm that we do not skip assignment incorrectly.
+ if (!am.isRunning()) {
Review comment:
Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org