You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2018/12/04 09:04:28 UTC
[myfaces] branch 2.3.x updated: MYFACES-4271 [perf]
DefaultViewHandlerSupport cache is not always used
This is an automated email from the ASF dual-hosted git repository.
tandraschko pushed a commit to branch 2.3.x
in repository https://gitbox.apache.org/repos/asf/myfaces.git
The following commit(s) were added to refs/heads/2.3.x by this push:
new d1bf2be MYFACES-4271 [perf] DefaultViewHandlerSupport cache is not always used
d1bf2be is described below
commit d1bf2bed0435a7b8ab77a3699052b25d2d9ee627
Author: Thomas Andraschko <ta...@apache.org>
AuthorDate: Tue Dec 4 10:04:23 2018 +0100
MYFACES-4271 [perf] DefaultViewHandlerSupport cache is not always used
---
.../java/org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java | 3 ---
.../apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java | 2 +-
.../org/apache/myfaces/shared/view/JspViewDeclarationLanguageBase.java | 2 +-
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/impl/src/main/java/org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java b/impl/src/main/java/org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
index c685f41..5ddaecd 100644
--- a/impl/src/main/java/org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
+++ b/impl/src/main/java/org/apache/myfaces/lifecycle/DefaultRestoreViewSupport.java
@@ -28,7 +28,6 @@ import java.util.logging.Logger;
import javax.faces.FacesException;
import javax.faces.FactoryFinder;
-import javax.faces.application.ProjectStage;
import javax.faces.application.ViewHandler;
import javax.faces.component.UIComponent;
import javax.faces.component.visit.VisitCallback;
@@ -43,13 +42,11 @@ import javax.faces.render.RenderKitFactory;
import javax.faces.render.ResponseStateManager;
import javax.faces.view.ViewDeclarationLanguage;
-import org.apache.myfaces.buildtools.maven2.plugin.builder.annotation.JSFWebConfigParam;
import org.apache.myfaces.shared.application.FacesServletMapping;
import org.apache.myfaces.shared.application.InvalidViewIdException;
import org.apache.myfaces.shared.util.Assert;
import org.apache.myfaces.shared.util.ConcurrentLRUCache;
import org.apache.myfaces.shared.util.ExternalContextUtils;
-import org.apache.myfaces.shared.util.WebConfigParamUtils;
import org.apache.myfaces.shared.application.CheckedViewIdsCache;
/**
diff --git a/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java b/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
index 8ab562d..2339a24 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
@@ -2167,7 +2167,7 @@ public class FaceletViewDeclarationLanguage extends FaceletViewDeclarationLangua
{
if (_cachedViewHandlerSupport == null)
{
- _cachedViewHandlerSupport = new DefaultViewHandlerSupport();
+ _cachedViewHandlerSupport = new DefaultViewHandlerSupport(context);
}
return _cachedViewHandlerSupport.calculateViewId(context, viewId);
diff --git a/shared/src/main/java/org/apache/myfaces/shared/view/JspViewDeclarationLanguageBase.java b/shared/src/main/java/org/apache/myfaces/shared/view/JspViewDeclarationLanguageBase.java
index 461d246..2eae11c 100644
--- a/shared/src/main/java/org/apache/myfaces/shared/view/JspViewDeclarationLanguageBase.java
+++ b/shared/src/main/java/org/apache/myfaces/shared/view/JspViewDeclarationLanguageBase.java
@@ -370,7 +370,7 @@ public abstract class JspViewDeclarationLanguageBase extends ViewDeclarationLang
{
if (_cachedViewHandlerSupport == null)
{
- _cachedViewHandlerSupport = new DefaultViewHandlerSupport();
+ _cachedViewHandlerSupport = new DefaultViewHandlerSupport(context);
}
return _cachedViewHandlerSupport.calculateViewId(context, viewId);