[GitHub] [maven] slawekjaranowski commented on a change in pull request #650: MNG 7263

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #650:
URL: https://github.com/apache/maven/pull/650#discussion_r780083814



##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/providers/CleanLifecycleProvider.java
##########
@@ -19,45 +19,33 @@
  * under the License.
  */
 
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashMap;
-
 import javax.inject.Inject;
 import javax.inject.Named;
-import javax.inject.Provider;
 import javax.inject.Singleton;
 
-import org.apache.maven.lifecycle.Lifecycle;
-import org.apache.maven.lifecycle.mapping.LifecyclePhase;
-
+/**
+ * {@code clean} lifecycle provider.
+ */
 @Named( "clean" )
 @Singleton
 public final class CleanLifecycleProvider
-    implements Provider<Lifecycle>
+    extends AbstractLifecycleProvider
 {
-  private final Lifecycle lifecycle;
+    private static final String LIFECYCLE_ID = "clean";
 
-  @Inject
-  public CleanLifecycleProvider()
-  {
-    HashMap<String, LifecyclePhase> phases = new HashMap<>();
-    phases.put( "clean", new LifecyclePhase( "org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean" ) );
-
-    this.lifecycle = new Lifecycle(
+    private static final String[] PHASES = {
+        "pre-clean",
         "clean",
-        Collections.unmodifiableList( Arrays.asList(
-                "pre-clean",
-                "clean",
-                "post-clean"
-        ) ),
-        Collections.unmodifiableMap( phases )
-    );
-  }
-
-  @Override
-  public Lifecycle get()
-  {
-    return lifecycle;
-  }
+        "post-clean"
+    };
+
+    private static final String[] BINDINGS = {
+        "clean", "org.apache.maven.plugins:maven-clean-plugin:3.1.0:clean"
+    };
+
+    @Inject
+    public CleanLifecycleProvider()
+    {

Review comment:
       Why `Inject` on constructor without arguments?
   What should be injected ... ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org