[GitHub] [spark] WeichenXu123 commented on a diff in pull request #40349: [SPARK-42725][CONNECT][PYTHON] Make LiteralExpression support array params

["WeichenXu123 (via GitHub)" <gi...@apache.org>]

WeichenXu123 commented on code in PR #40349:
URL: https://github.com/apache/spark/pull/40349#discussion_r1130844165


##########
python/pyspark/sql/tests/connect/test_connect_column.py:
##########
@@ -437,7 +436,6 @@ def test_literal_with_unsupported_type(self):
             (0.1, DecimalType()),
             (datetime.date(2022, 12, 13), TimestampType()),
             (datetime.timedelta(1, 2, 3), DateType()),
-            ([1, 2, 3], ArrayType(IntegerType())),

Review Comment:
   Let's add test for Array<Array<T>> type as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org