You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/10/08 16:20:30 UTC
[Impala-ASF-CR] PROTOTYPE IMPALA-15519: Allow several in-flight RPCs per channel
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25067
Change subject: PROTOTYPE IMPALA-15519: Allow several in-flight RPCs per channel
......................................................................
PROTOTYPE IMPALA-15519: Allow several in-flight RPCs per channel
A data stream channel allowed one TransmitData RPC in flight, so a
sender moved at most one batch per network round trip.
The per-RPC state of a channel (controller, response, in-flight batch,
outbound batch) moves into a slot struct, and a channel owns K slots.
TransmitData waits until fewer than K RPCs are in flight; FlushFinal
and EndDataStream wait for all of them. The first RPC error is kept,
and teardown cancels and waits for every slot. K is set by the new
flag --data_stream_sender_max_inflight_rpcs (default 2, at most 8) for
hash and random partitioned senders. Broadcast, merging, Kudu and
directed senders keep 1.
Each channel now holds K+1 batches. The planner's memory estimate in
DataStreamSink is not updated yet.
Testing:
- TPC-DS SF100, 5 executors, MT_DOP=0, K=2: total 374.6 s -> 307.1 s
(-18%). Results matched master, except q56 and q65, whose LIMIT
ties vary between runs. No new tests.
Change-Id: I7cd3ceedafc8558e09c10451b45e28d6c5b44c2c
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M be/src/runtime/krpc-data-stream-sender.cc
1 file changed, 265 insertions(+), 154 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/25067/1
--
To view, visit http://gerrit.cloudera.org:8080/25067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cd3ceedafc8558e09c10451b45e28d6c5b44c2c
Gerrit-Change-Number: 25067
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] PROTOTYPE IMPALA-15519: Allow several in-flight RPCs per channel
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25067 )
Change subject: PROTOTYPE IMPALA-15519: Allow several in-flight RPCs per channel
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24423/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/25067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd3ceedafc8558e09c10451b45e28d6c5b44c2c
Gerrit-Change-Number: 25067
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2026 16:47:50 +0000
Gerrit-HasComments: No