[GitHub] [incubator-hugegraph-computer] coderzc commented on a diff in pull request #243: feat: implement `MessageRecvManager` and `DataClientManager` for fast-fail

["coderzc (via GitHub)" <gi...@apache.org>]

coderzc commented on code in PR #243:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/243#discussion_r1200292291


##########
computer-core/src/main/java/org/apache/hugegraph/computer/core/receiver/MessageRecvManager.java:
##########
@@ -138,9 +142,9 @@ public void onChannelInactive(ConnectionId connectionId) {
     @Override
     public void exceptionCaught(TransportException cause,
                                 ConnectionId connectionId) {
-        // TODO: implement failover
         LOG.warn("Exception caught for connection:{}, root cause:",
                  connectionId, cause);
+        connManager.shutdownClients();

Review Comment:
   It seems to be `connManager.shutdownServer()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org