You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Maarten Billemont (JIRA)" <ji...@apache.org> on 2010/06/03 09:34:54 UTC
[jira] Created: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
-----------------------------------------------------------
Key: WICKET-2906
URL: https://issues.apache.org/jira/browse/WICKET-2906
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Maarten Billemont
Fix For: 1.4.7
Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
{code}
protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
{
return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
"'");
}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875009#action_12875009 ]
Johan Compagner commented on WICKET-2906:
-----------------------------------------
making changes to this can only be done in 1.5, because this results in api breaks.
The thing is that
getCallbackScript and generateCallbackScript could be really just 1 method..
Except i guess that some do use generate standalone
But if you have a nice patch that would result in the same thing please attach it.
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Maarten Billemont
> Fix For: 1.4.7
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-2906:
-------------------------------------
Fix Version/s: (was: 1.5-M3)
1.5-M4
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Maarten Billemont
> Priority: Minor
> Fix For: 1.5-M4
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Maarten Billemont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874995#action_12874995 ]
Maarten Billemont commented on WICKET-2906:
-------------------------------------------
OK, so this string is an unmatched JS function invocation by design. That is just nasty.
How about you convert it to something safe and correct like generateCallbackScript(String function, String... args) ?
Then you'd do:
{code}
protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
{
return generateCallbackScript("wicketAjaxGet", getCallbackUrl(onlyTargetActivePage));
}
{code}
Immediately fixing the potentially broken inject-an-arbitrary-string-in-a-literally-quoted-value too.
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Maarten Billemont
> Fix For: 1.4.7
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-2906:
------------------------------------
Fix Version/s: 1.5-M1
(was: 1.4.7)
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Maarten Billemont
> Fix For: 1.5-M1
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2906:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Maarten Billemont
> Fix For: 1.5-M2
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2906:
----------------------------------
Fix Version/s: 1.5-M3
(was: 1.5-M2)
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Maarten Billemont
> Priority: Minor
> Fix For: 1.5-M3
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2906) Missing ) on
AbstractDefaultAjaxBehaviour#getCallbackScript
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-2906:
----------------------------------
Issue Type: Improvement (was: Bug)
Priority: Minor (was: Major)
> Missing ) on AbstractDefaultAjaxBehaviour#getCallbackScript
> -----------------------------------------------------------
>
> Key: WICKET-2906
> URL: https://issues.apache.org/jira/browse/WICKET-2906
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Maarten Billemont
> Priority: Minor
> Fix For: 1.5-M2
>
>
> Am I blindly overlooking something, or are we missing a ) here, in AbstractDefaultAjaxBehaviour#getCallbackScript (at line 119):
> {code}
> protected CharSequence getCallbackScript(boolean onlyTargetActivePage)
> {
> return generateCallbackScript("wicketAjaxGet('" + getCallbackUrl(onlyTargetActivePage) +
> "'");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.