You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/28 14:50:28 UTC

[GitHub] [flink] zentol commented on a change in pull request #7807: [FLINK-11723][network] Remove KvState related components from Network…

zentol commented on a change in pull request #7807: [FLINK-11723][network] Remove KvState related components from Network…
URL: https://github.com/apache/flink/pull/7807#discussion_r270039172
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ##########
 @@ -82,27 +77,30 @@
 	private final MemoryManager memoryManager;
 	private final IOManager ioManager;
 	private final NetworkEnvironment networkEnvironment;
+	private final KvStateService kvStateService;
 	private final BroadcastVariableManager broadcastVariableManager;
 	private final TaskSlotTable taskSlotTable;
 	private final JobManagerTable jobManagerTable;
 	private final JobLeaderService jobLeaderService;
 	private final TaskExecutorLocalStateStoresManager taskManagerStateStore;
 
 	TaskManagerServices(
-		TaskManagerLocation taskManagerLocation,
-		MemoryManager memoryManager,
-		IOManager ioManager,
 
 Review comment:
   always stick to the existing indentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services