You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "uncleGen (JIRA)" <ji...@apache.org> on 2016/08/12 09:03:20 UTC

[jira] [Updated] (HADOOP-13491) fix several warnings from findbugs

     [ https://issues.apache.org/jira/browse/HADOOP-13491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

uncleGen updated HADOOP-13491:
------------------------------
    Description: 

Code	Warning
RR	org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.seek(long) ignores result of java.io.InputStream.skip(long)
Bug type SR_NOT_CHECKED (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.seek(long)
Called method java.io.InputStream.skip(long)
At AliyunOSSInputStream.java:[line 235]

RR	org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject() ignores result of java.io.FileInputStream.skip(long)
Bug type SR_NOT_CHECKED (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
Called method java.io.FileInputStream.skip(long)
At AliyunOSSOutputStream.java:[line 177]

RV	Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.close()
Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.close()
Called method java.io.File.delete()
At AliyunOSSOutputStream.java:[line 116]


Code	Warning
IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.partRemaining; locked 90% of time
Bug type IS2_INCONSISTENT_SYNC (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.partRemaining
Synchronized 90% of the time
Unsynchronized access at AliyunOSSInputStream.java:[line 234]
Synchronized access at AliyunOSSInputStream.java:[line 106]
Synchronized access at AliyunOSSInputStream.java:[line 168]
Synchronized access at AliyunOSSInputStream.java:[line 189]
Synchronized access at AliyunOSSInputStream.java:[line 188]
Synchronized access at AliyunOSSInputStream.java:[line 188]
Synchronized access at AliyunOSSInputStream.java:[line 190]
Synchronized access at AliyunOSSInputStream.java:[line 113]
Synchronized access at AliyunOSSInputStream.java:[line 131]
Synchronized access at AliyunOSSInputStream.java:[line 131]

IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.position; locked 66% of time
Bug type IS2_INCONSISTENT_SYNC (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.position
Synchronized 66% of the time
Unsynchronized access at AliyunOSSInputStream.java:[line 232]
Unsynchronized access at AliyunOSSInputStream.java:[line 234]
Unsynchronized access at AliyunOSSInputStream.java:[line 234]
Unsynchronized access at AliyunOSSInputStream.java:[line 235]
Unsynchronized access at AliyunOSSInputStream.java:[line 236]
Unsynchronized access at AliyunOSSInputStream.java:[line 245]
Synchronized access at AliyunOSSInputStream.java:[line 222]
Synchronized access at AliyunOSSInputStream.java:[line 105]
Synchronized access at AliyunOSSInputStream.java:[line 167]
Synchronized access at AliyunOSSInputStream.java:[line 169]
Synchronized access at AliyunOSSInputStream.java:[line 187]
Synchronized access at AliyunOSSInputStream.java:[line 187]
Synchronized access at AliyunOSSInputStream.java:[line 113]
Synchronized access at AliyunOSSInputStream.java:[line 114]
Synchronized access at AliyunOSSInputStream.java:[line 130]
Synchronized access at AliyunOSSInputStream.java:[line 130]
Synchronized access at AliyunOSSInputStream.java:[line 259]
Synchronized access at AliyunOSSInputStream.java:[line 266]

IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.wrappedStream; locked 85% of time
Bug type IS2_INCONSISTENT_SYNC (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.wrappedStream
Synchronized 85% of the time
Unsynchronized access at AliyunOSSInputStream.java:[line 235]
Synchronized access at AliyunOSSInputStream.java:[line 92]
Synchronized access at AliyunOSSInputStream.java:[line 96]
Synchronized access at AliyunOSSInputStream.java:[line 101]
Synchronized access at AliyunOSSInputStream.java:[line 102]
Synchronized access at AliyunOSSInputStream.java:[line 178]
Synchronized access at AliyunOSSInputStream.java:[line 123]


Code	Warning
REC	Exception is caught when Exception is not thrown in org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.multipartCopy(String, long, String)
Bug type REC_CATCH_EXCEPTION (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem
In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.multipartCopy(String, long, String)
At AliyunOSSFileSystem.java:[line 785]

REC	Exception is caught when Exception is not thrown in org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
Bug type REC_CATCH_EXCEPTION (click for details) 
In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
At AliyunOSSOutputStream.java:[line 201]

> fix several warnings from findbugs
> ----------------------------------
>
>                 Key: HADOOP-13491
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13491
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: HADOOP-12756
>            Reporter: uncleGen
>            Assignee: uncleGen
>             Fix For: HADOOP-12756
>
>
> Code	Warning
> RR	org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.seek(long) ignores result of java.io.InputStream.skip(long)
> Bug type SR_NOT_CHECKED (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
> In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.seek(long)
> Called method java.io.InputStream.skip(long)
> At AliyunOSSInputStream.java:[line 235]
> RR	org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject() ignores result of java.io.FileInputStream.skip(long)
> Bug type SR_NOT_CHECKED (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
> In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
> Called method java.io.FileInputStream.skip(long)
> At AliyunOSSOutputStream.java:[line 177]
> RV	Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.close()
> Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
> In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.close()
> Called method java.io.File.delete()
> At AliyunOSSOutputStream.java:[line 116]
> Code	Warning
> IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.partRemaining; locked 90% of time
> Bug type IS2_INCONSISTENT_SYNC (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
> Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.partRemaining
> Synchronized 90% of the time
> Unsynchronized access at AliyunOSSInputStream.java:[line 234]
> Synchronized access at AliyunOSSInputStream.java:[line 106]
> Synchronized access at AliyunOSSInputStream.java:[line 168]
> Synchronized access at AliyunOSSInputStream.java:[line 189]
> Synchronized access at AliyunOSSInputStream.java:[line 188]
> Synchronized access at AliyunOSSInputStream.java:[line 188]
> Synchronized access at AliyunOSSInputStream.java:[line 190]
> Synchronized access at AliyunOSSInputStream.java:[line 113]
> Synchronized access at AliyunOSSInputStream.java:[line 131]
> Synchronized access at AliyunOSSInputStream.java:[line 131]
> IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.position; locked 66% of time
> Bug type IS2_INCONSISTENT_SYNC (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
> Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.position
> Synchronized 66% of the time
> Unsynchronized access at AliyunOSSInputStream.java:[line 232]
> Unsynchronized access at AliyunOSSInputStream.java:[line 234]
> Unsynchronized access at AliyunOSSInputStream.java:[line 234]
> Unsynchronized access at AliyunOSSInputStream.java:[line 235]
> Unsynchronized access at AliyunOSSInputStream.java:[line 236]
> Unsynchronized access at AliyunOSSInputStream.java:[line 245]
> Synchronized access at AliyunOSSInputStream.java:[line 222]
> Synchronized access at AliyunOSSInputStream.java:[line 105]
> Synchronized access at AliyunOSSInputStream.java:[line 167]
> Synchronized access at AliyunOSSInputStream.java:[line 169]
> Synchronized access at AliyunOSSInputStream.java:[line 187]
> Synchronized access at AliyunOSSInputStream.java:[line 187]
> Synchronized access at AliyunOSSInputStream.java:[line 113]
> Synchronized access at AliyunOSSInputStream.java:[line 114]
> Synchronized access at AliyunOSSInputStream.java:[line 130]
> Synchronized access at AliyunOSSInputStream.java:[line 130]
> Synchronized access at AliyunOSSInputStream.java:[line 259]
> Synchronized access at AliyunOSSInputStream.java:[line 266]
> IS	Inconsistent synchronization of org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.wrappedStream; locked 85% of time
> Bug type IS2_INCONSISTENT_SYNC (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream
> Field org.apache.hadoop.fs.aliyun.oss.AliyunOSSInputStream.wrappedStream
> Synchronized 85% of the time
> Unsynchronized access at AliyunOSSInputStream.java:[line 235]
> Synchronized access at AliyunOSSInputStream.java:[line 92]
> Synchronized access at AliyunOSSInputStream.java:[line 96]
> Synchronized access at AliyunOSSInputStream.java:[line 101]
> Synchronized access at AliyunOSSInputStream.java:[line 102]
> Synchronized access at AliyunOSSInputStream.java:[line 178]
> Synchronized access at AliyunOSSInputStream.java:[line 123]
> Code	Warning
> REC	Exception is caught when Exception is not thrown in org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.multipartCopy(String, long, String)
> Bug type REC_CATCH_EXCEPTION (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem
> In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.multipartCopy(String, long, String)
> At AliyunOSSFileSystem.java:[line 785]
> REC	Exception is caught when Exception is not thrown in org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
> Bug type REC_CATCH_EXCEPTION (click for details) 
> In class org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream
> In method org.apache.hadoop.fs.aliyun.oss.AliyunOSSOutputStream.multipartUploadObject()
> At AliyunOSSOutputStream.java:[line 201]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org