You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WeichenXu123 <gi...@git.apache.org> on 2018/01/31 18:55:47 UTC

[GitHub] spark pull request #20457: [SPARK-23110][MINOR] Make linearRegressionModel c...

GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/spark/pull/20457

    [SPARK-23110][MINOR] Make linearRegressionModel constructor private

    ## What changes were proposed in this pull request?
    
    make linearRegressionModel constructor private[ml]
    
    ## How was this patch tested?
    
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/spark lir_model_java_compat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20457
    
----
commit cdcce18425ee669b99323cf94bd04015ee080439
Author: WeichenXu <we...@...>
Date:   2018-01-31T18:51:56Z

    init pr

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/441/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20457: [SPARK-23110][MINOR] Make linearRegressionModel c...

Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 closed the pull request at:

    https://github.com/apache/spark/pull/20457


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20457: [SPARK-23110][MINOR] Make linearRegressionModel c...

Posted by WeichenXu123 <gi...@git.apache.org>.
GitHub user WeichenXu123 reopened a pull request:

    https://github.com/apache/spark/pull/20457

    [SPARK-23110][MINOR] Make linearRegressionModel constructor private

    ## What changes were proposed in this pull request?
    
    make linearRegressionModel constructor private[ml]
    
    ## How was this patch tested?
    
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/spark lir_model_java_compat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20457
    
----
commit cdcce18425ee669b99323cf94bd04015ee080439
Author: WeichenXu <we...@...>
Date:   2018-01-31T18:51:56Z

    init pr

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86888/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    It's covered in this PR #20459 So go there discuss.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    **[Test build #86909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86909/testReport)** for PR 20457 at commit [`cdcce18`](https://github.com/apache/spark/commit/cdcce18425ee669b99323cf94bd04015ee080439).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86909/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    **[Test build #86888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86888/testReport)** for PR 20457 at commit [`cdcce18`](https://github.com/apache/spark/commit/cdcce18425ee669b99323cf94bd04015ee080439).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Just to be sure -- this was never public in a released version of Spark right? so hiding it isn't changing an API.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20457: [SPARK-23110][MINOR] Make linearRegressionModel c...

Posted by WeichenXu123 <gi...@git.apache.org>.
Github user WeichenXu123 closed the pull request at:

    https://github.com/apache/spark/pull/20457


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    **[Test build #86909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86909/testReport)** for PR 20457 at commit [`cdcce18`](https://github.com/apache/spark/commit/cdcce18425ee669b99323cf94bd04015ee080439).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20457: [SPARK-23110][MINOR] Make linearRegressionModel construc...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20457
  
    **[Test build #86888 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86888/testReport)** for PR 20457 at commit [`cdcce18`](https://github.com/apache/spark/commit/cdcce18425ee669b99323cf94bd04015ee080439).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org