You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by shanthoosh <gi...@git.apache.org> on 2018/05/18 00:57:52 UTC

[GitHub] samza pull request #527: SAMZA-1720: Remove javafx.util dependency from samz...

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/527

    SAMZA-1720: Remove javafx.util dependency from samza-sql tests.

    In samza-sql module, currently few test classes(`TestSamzaSqlRelMessageSerde` and `TestSamzaSqlRelRecordSerde`) are dependent upon `javax.util.Pair` class. `javafx.util.Pair` is not supported by default in all JDK builds(example; open-jdk java-8 doesn't support `javafx` module) and it belongs to `javafx` package which is primarily used for developing GUI applications. This dependency is removed and replaced with `Pair` class from `apache-commons`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza SAMZA-1720

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #527
    
----
commit 43aa4a15aca1d6242276b601d8ba7e598eba2bca
Author: Shanthoosh Venkataraman <sa...@...>
Date:   2018-05-18T00:55:16Z

    SAMZA-1720: Remove javafx.util dependency from samza-sql tests.
    
    In samza-sql module, currently few test classes(TestSamzaSqlRelMessageSerde and TestSamzaSqlRelRecordSerde) are dependent upon javax.util.Pair class.
    javafx.util.Pair is not supported by default in all JDK builds(example; open-jdk java-8 doesn't support javafx module) and it belongs to javafx package
    which is primarily used for developing GUI applications. This dependency is removed and replaced with Pair class from apache-commons.

----


---

[GitHub] samza pull request #527: SAMZA-1720: Remove javafx.util dependency from samz...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/527


---