You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/11 02:03:11 UTC
[GitHub] [spark] wangyum opened a new pull request, #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
wangyum opened a new pull request, #37475:
URL: https://github.com/apache/spark/pull/37475
### What changes were proposed in this pull request?
This PR enhances `LimitPushDown` to support push local limit to both sides if it is outer join and join condition is empty.
For example:
<img width="706" alt="image" src="https://user-images.githubusercontent.com/5399861/184052707-ebf50748-6870-4650-84c3-65d79b18ba9d.png">
### Why are the changes needed?
Improve query performance.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
URL: https://github.com/apache/spark/pull/37475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37475:
URL: https://github.com/apache/spark/pull/37475#issuecomment-1223645426
cc @sigmod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37475:
URL: https://github.com/apache/spark/pull/37475#issuecomment-1233012929
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37475:
URL: https://github.com/apache/spark/pull/37475#issuecomment-1221679382
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37475:
URL: https://github.com/apache/spark/pull/37475#issuecomment-1222037620
cc @sigmod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37475: [SPARK-40040][SQL] Push local limit to both sides if join condition is empty
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37475:
URL: https://github.com/apache/spark/pull/37475#issuecomment-1222039601
The idea is very simple. We should explain the rationale for this optimization in the PR description, instead of giving a screenshot which doesn't provide much value to understand this optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org