[GitHub] [hadoop] goiri commented on a diff in pull request #5828: YARN-11529 Add metrics for ContainerMonitorImpl.

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5828:
URL: https://github.com/apache/hadoop/pull/5828#discussion_r1260093389


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java:
##########
@@ -497,6 +497,7 @@ private class MonitoringThread extends Thread {
     public void run() {
 
       while (!stopped && !Thread.currentThread().isInterrupted()) {
+        long start = System.currentTimeMillis();

Review Comment:
   I think we prefer using monotonicNow()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org