You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/08/13 03:39:55 UTC
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14053
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
IMPALA-8859: fix test_global_config_file for remote clusters
I think the bug is that necessary environment variables were
not passed in - the environment was clobbered instead of
just having the necessary variable added.
Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
---
M tests/shell/test_shell_commandline.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/14053/1
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 17:15:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4778/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 06:40:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 1: Code-Review+2
Sorry -- didn't notice this when you posted it.
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 17:12:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4229/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 04:20:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4800/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 17:15:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 10:52:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:21:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8859: fix test global config file for remote clusters
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14053 )
Change subject: IMPALA-8859: fix test_global_config_file for remote clusters
......................................................................
IMPALA-8859: fix test_global_config_file for remote clusters
I think the bug is that necessary environment variables were
not passed in - the environment was clobbered instead of
just having the necessary variable added.
Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Reviewed-on: http://gerrit.cloudera.org:8080/14053
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/shell/test_shell_commandline.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I448e5a7dfc0ab6fd53182a593e2fff1a12a10fd7
Gerrit-Change-Number: 14053
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>