You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/08 19:11:32 UTC

[GitHub] [superset] serenajiang commented on pull request #17881: fix(sql): unable to filter text with quotes

serenajiang commented on pull request #17881:
URL: https://github.com/apache/superset/pull/17881#issuecomment-1032966222


   @villebro @stephenLYZ While this fix is definitely a good direction, can we make sure to add this to `UPDATING.md` as a breaking change, since it changes how string filters work?
   
   After deploying this fix, we found out that a lot of our users had been wrapping strings in quotes, so a ton of important charts broke. I think the previous behavior made some people think that you had to wrap string filter values in quotes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org