You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Laxman (JIRA)" <ji...@apache.org> on 2011/07/27 15:03:18 UTC
[jira] [Created] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
AuthFLE is throwing NPE when servers are configured with different election ports.
----------------------------------------------------------------------------------
Key: ZOOKEEPER-1137
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection
Affects Versions: 3.3.3
Reporter: Laxman
Assignee: Laxman
Priority: Critical
AuthFLE is throwing NPE when servers are configured with different election ports.
*Configuration*
{noformat}
server.1 = 10.18.52.25:2888:3888
server.2 = 10.18.52.205:2889:3889
server.3 = 10.18.52.144:2899:3890
{noformat}
*Logs*
{noformat}
2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
java.lang.NullPointerException
at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
at java.lang.Thread.run(Thread.java:619)
2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
java.lang.NullPointerException
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138470#comment-13138470 ]
Patrick Hunt commented on ZOOKEEPER-1137:
-----------------------------------------
Bug Flavio more? ;-)
Seriously, discuss with Flavio and come up with a patch & test that is deterministic.
Another option would be to refactor to allow the code in question to be tested as a true unit test, rather than as a system test (we need to work on that in general in ZK).
Mockito?
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman updated ZOOKEEPER-1137:
------------------------------
Attachment: ZOOKEEPER-1137.patch
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman updated ZOOKEEPER-1137:
------------------------------
Attachment: ZOOKEEPER-1137.patch
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman updated ZOOKEEPER-1137:
------------------------------
Assignee: (was: Laxman)
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071707#comment-13071707 ]
Laxman commented on ZOOKEEPER-1137:
-----------------------------------
Following piece of code in AuthFLE class looks to be problematic.
{code}
for (QuorumServer server : self.getVotingView().values()) {
InetSocketAddress saddr = new InetSocketAddress(server.addr
.getAddress(), port);
addrChallengeMap.put(saddr, new ConcurrentHashMap<Long, Long>());
}
{code}
We are populating the addrChallengeMap with same port all the times.
Ideally, this should be
{code}
for (QuorumServer server : self.getVotingView().values()) {
addrChallengeMap.put(server.electionAddr, new ConcurrentHashMap<Long, Long>());
}
{code}
Any other thoughts?
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laxman updated ZOOKEEPER-1137:
------------------------------
Attachment: ZOOKEEPER-1137.WithTest.patch
Flavio, attached the patch including the test for AuthFLE. This test is intermittently failing in my env. Please review and let me know if you have any suggestions. Check if we can proceed with committing the changes without test if we are not able to find out the actual problem.
As I already mentioned, patch has been tested manually.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072171#comment-13072171 ]
Laxman commented on ZOOKEEPER-1137:
-----------------------------------
Thanks for the info Flavio. I really don't have a specific use case. We found this problem while exploring different features. I've a patch to fix this problem as I mentioned in earlier comments and currently verifying the same.
Even if this is going to be deprecated we can't have a NPE. no?
Please let me know if I can upload the patch.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078593#comment-13078593 ]
Laxman commented on ZOOKEEPER-1137:
-----------------------------------
Hi Flavio, quorum always fails to start if we configure different election ports. Also, I already tried to adapt FLE Test to use Auth FLE but its failing randomly [May be due to UDP]. That was the reason for not adding a test. Patch has been verified manually by configuring different ports. Quorum started with no issues after fix.
I will upload the patch including test case I've added. Please review and let me know what I'm missing. So that I can correct it.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071751#comment-13071751 ]
Flavio Junqueira commented on ZOOKEEPER-1137:
---------------------------------------------
Hi Laxman, We haven't been maintaining the AuthFLE implementation, and we have been talking about deprecating it for a long time. Do you have any particular reason why you'd like to fix it, like a use case, or you're simply exploring?
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084989#comment-13084989 ]
Hadoop QA commented on ZOOKEEPER-1137:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490410/ZOOKEEPER-1137.patch
against trunk revision 1157698.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/458//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/458//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/458//console
This message is automatically generated.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Laxman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138203#comment-13138203 ]
Laxman commented on ZOOKEEPER-1137:
-----------------------------------
Thanks for taking a look at it Pat.
As mentioned in my earlier comments I failed to write a test which passes consistently.
Following are the patches already attached.
ZOOKEEPER-1137.patch - Patch without testcase - Ready to commit - Verified manually
ZOOKEEPER-1137.WithTest.patch - Patch with testcase - Test is failing intermittently
Any suggestions?
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076306#comment-13076306 ]
Flavio Junqueira commented on ZOOKEEPER-1137:
---------------------------------------------
The modification is minor, and I'm ok with committing it without a test. Does anyone else have an opinion?
I was actually suggesting a general test for AuthFLE. We have no test exercising AuthFLE currently. If you have one, it would be great.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130866#comment-13130866 ]
Hadoop QA commented on ZOOKEEPER-1137:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490410/ZOOKEEPER-1137.patch
against trunk revision 1185994.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/632//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/632//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/632//console
This message is automatically generated.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072177#comment-13072177 ]
Flavio Junqueira commented on ZOOKEEPER-1137:
---------------------------------------------
Sure, go ahead and upload a patch. Having a test for AuthFLE would also be useful.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112236#comment-13112236 ]
Hadoop QA commented on ZOOKEEPER-1137:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490410/ZOOKEEPER-1137.patch
against trunk revision 1172406.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/576//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/576//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/576//console
This message is automatically generated.
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.WithTest.patch, ZOOKEEPER-1137.patch, ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1137) AuthFLE is throwing NPE when
servers are configured with different election ports.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078295#comment-13078295 ]
Flavio Junqueira commented on ZOOKEEPER-1137:
---------------------------------------------
On a second thought about it, if we get an NPE when using different ports, then perhaps we could adapt the FLE test to use AuthFLE and then be able to reproduce the problem?
> AuthFLE is throwing NPE when servers are configured with different election ports.
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1137
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1137
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.3.3
> Reporter: Laxman
> Assignee: Laxman
> Priority: Critical
> Attachments: ZOOKEEPER-1137.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> AuthFLE is throwing NPE when servers are configured with different election ports.
> *Configuration*
> {noformat}
> server.1 = 10.18.52.25:2888:3888
> server.2 = 10.18.52.205:2889:3889
> server.3 = 10.18.52.144:2899:3890
> {noformat}
> *Logs*
> {noformat}
> 2011-07-22 16:06:22,404 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:65170:AuthFastLeaderElection@844] - Election tally
> 2011-07-22 16:06:29,483 - ERROR [WorkerSender Thread: 6:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 6,5,main] died
> java.lang.NullPointerException
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.process(AuthFastLeaderElection.java:488)
> at org.apache.zookeeper.server.quorum.AuthFastLeaderElection$Messenger$WorkerSender.run(AuthFastLeaderElection.java:432)
> at java.lang.Thread.run(Thread.java:619)
> 2011-07-22 16:06:29,583 - ERROR [WorkerSender Thread: 1:NIOServerCnxn$Factory$1@81] - Thread Thread[WorkerSender Thread: 1,5,main] died
> java.lang.NullPointerException
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira