You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2015/03/11 15:18:39 UTC

[jira] [Comment Edited] (OAK-2464) Optimize read of known non-existing children

    [ https://issues.apache.org/jira/browse/OAK-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356901#comment-14356901 ] 

Julian Reschke edited comment on OAK-2464 at 3/11/15 2:18 PM:
--------------------------------------------------------------

This change causes a reproducible failure on my systems:

addNodeGetNode(org.apache.jackrabbit.oak.plugins.document.SimpleTest)  Time elapsed: 0.453 sec  <<< FAILURE!
java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:92)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertNotNull(Assert.java:526)
        at org.junit.Assert.assertNotNull(Assert.java:537)
        at org.apache.jackrabbit.oak.plugins.document.SimpleTest.addNodeGetNode(SimpleTest.java:86)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)


[~chetanm] removed "fix version 1.0.13" and backing out the change for now


was (Author: reschke):
This change causes a reproducible failure on my systems:

addNodeGetNode(org.apache.jackrabbit.oak.plugins.document.SimpleTest)  Time elapsed: 0.453 sec  <<< FAILURE!
java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:92)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at org.junit.Assert.assertNotNull(Assert.java:526)
        at org.junit.Assert.assertNotNull(Assert.java:537)
        at org.apache.jackrabbit.oak.plugins.document.SimpleTest.addNodeGetNode(SimpleTest.java:86)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)


> Optimize read of known non-existing children
> --------------------------------------------
>
>                 Key: OAK-2464
>                 URL: https://issues.apache.org/jira/browse/OAK-2464
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Vikas Saurabh
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.1.6
>
>         Attachments: 0001-OAK-2464-Optimize-read-of-known-non-existing-childre.patch, OAK-2464-Sort order test case.patch, OAK-2464-Take2.patch
>
>
> Reading a non-existing node always queries down to {{DocumentStore}}. {{DocumentNodeStore}} should consider {{nodeChildrenCache}} to see if it already knows about non-existence and avoid a look up into {{DocumentStore}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)