You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@predictionio.apache.org by chanlee514 <gi...@git.apache.org> on 2016/11/08 01:37:53 UTC

[GitHub] incubator-predictionio pull request #325: Add git to Dockerfile

GitHub user chanlee514 opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/325

    Add git to Dockerfile

    For fetching templates via github

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chanlee514/incubator-predictionio temp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 7419ad4eccb0b714ed6d3ee12db952794a458c92
Author: Chan Lee <ch...@gmail.com>
Date:   2016-11-07T08:45:10Z

    Add git to Dockerfile
    
    For fetching templates via github

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #325: Add git to Dockerfile

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/325


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #325: Add git to Dockerfile

Posted by chanlee514 <gi...@git.apache.org>.

Github user chanlee514 commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/325
  
    The tests use latest version of standard Debian Linux image on Docker. I think it may be a good idea to use Alpine though since it's much smaller in size and may speed up the tests. 
    
    And thanks, I will go ahead and merge this now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #325: Add git to Dockerfile

Posted by pferrel <gi...@git.apache.org>.

Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/325
  
    Do we have Alpine as the container OS? This seems to be the standard Docker is pushing but this looks like Debian. 
    
    BTW You can merge this yourself now. We, as a group, like to review on Github but after a fair amount of time (3-4 days) without response feel free to ping someone or just merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---