[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2826: tools/esp32/Config.mk: Refine the usage of IDF binaries.

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2826:
URL: https://github.com/apache/incubator-nuttx/pull/2826#discussion_r573707850



##########
File path: tools/esp32/Config.mk
##########
@@ -22,12 +22,11 @@
 # and assemble source files and to insert the resulting object files into an
 # archive.  These replace the default definitions at tools/Config.mk
 
-ifdef BLOBDIR
-	BOOTLOADER=${BLOBDIR}/esp32core/bootloader.bin
-	PARTITION_TABLE=${BLOBDIR}/esp32core/partition-table.bin
-else
-	BOOTLOADER=$(IDF_PATH)/hello_world/build/bootloader/bootloader.bin
-	PARTITION_TABLE=$(IDF_PATH)/hello_world/build/partition_table/partition-table.bin
+ifdef ESPTOOL_BINDIR
+	BOOTLOADER=$(ESPTOOL_BINDIR)/bootloader.bin
+	PARTITION_TABLE=$(ESPTOOL_BINDIR)/partition-table.bin
+	FLASH_BL=0x1000 $(BOOTLOADER)
+	FLASH_PT=0x8000 $(PARTITION_TABLE)

Review comment:
       These are properties of the ROM bootloader, separating them would be just for cosmetic reasons.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org